Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > -----Original Message----- > From: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> > Sent: Thursday, November 30, 2023 4:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Ni, Ray <ray...@intel.com>; > Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Kinney, Michael D <michael.d.kin...@intel.com>; > Sun, Zailiang <zailiang....@intel.com>; Qian, Yi <yi.q...@intel.com>; > Taylor Beebe <taylor.d.be...@gmail.com>; Kubacki, Michael > <michael.kuba...@microsoft.com> > Subject: [edk2-platforms][PATCH v1] Vlv2TbltDevicePkg: Fix DxeCore Build > Failures > > Commit 7284c44 in edk2 introduces an incompatibility that causes any > project that uses DxeMain.inf to fail to build. This is due to the > addition of ImagePropertiesRecordLib, and a new added dependency on > that library in DxeMain. Platforms will not have this LibraryClass > defined in their DSC yet and hence currently fail to build. > > This changes addes ImagePropertiesRecordLib to Vlv2TbltDevicePkg > and resolves the build failure. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Zailiang Sun <zailiang....@intel.com> > Cc: Yi Qian <yi.q...@intel.com> > Cc: Taylor Beebe <taylor.d.be...@gmail.com> > Cc: Michael Kubacki <michael.kuba...@microsoft.com> > Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > --- > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 4adbaa6966..0c66705377 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -209,6 +209,7 @@ > > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoff > ExtraActionLibNull.inf > > DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf > !endif > + > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/Imag > ePropertiesRecordLib.inf > > # > # CryptLib > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index c7d9733dad..0689f275f1 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -211,6 +211,7 @@ > > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoff > ExtraActionLibNull.inf > > DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf > !endif > + > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/Imag > ePropertiesRecordLib.inf > > # > # CryptLib > -- > 2.39.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111953): https://edk2.groups.io/g/devel/message/111953 Mute This Topic: https://groups.io/mt/102906247/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
