Hey Taylor, I think I gotten everything in Platform/Intel, it should also fix QemuOpenBoardPkg and AmdMinBoardPkg. I saw that Levi also fixed ARM\VExpressPkg in https://edk2.groups.io/g/devel/message/111905. Everything else I'm not sure.
Thanks for being proactive on fixing it! Best Regards, Nate -----Original Message----- From: Taylor Beebe <taylor.d.be...@gmail.com> Sent: Thursday, November 30, 2023 4:22 PM To: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.c...@intel.com>; Ni, Ray <ray...@intel.com>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Kinney, Michael D <michael.d.kin...@intel.com>; Kelly Steele <kelly.ste...@intel.com>; Kubacki, Michael <michael.kuba...@microsoft.com> Subject: Re: [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures Hey Nate, I'm about to send out a series to add the library across the repo -- just having some smtp authentication issues :D Are you updating all the packages or just a subset? -Taylor On 11/30/2023 4:18 PM, Nate DeSimone wrote: > Commit 7284c44 in edk2 introduces an incompatibility that causes any > project that uses DxeMain.inf to fail to build. This is due to the > addition of ImagePropertiesRecordLib, and a new added dependency on > that library in DxeMain. Platforms will not have this LibraryClass > defined in their DSC yet and hence currently fail to build. > > This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg and > resolves the build failure. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Kelly Steele <kelly.ste...@intel.com> > Cc: Taylor Beebe <taylor.d.be...@gmail.com> > Cc: Michael Kubacki <michael.kuba...@microsoft.com> > Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > --- > Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 + > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > index 7cc548058a..40d9768336 100644 > --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > @@ -196,6 +196,7 @@ > !endif > > > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.i > nf > + > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordL > + ib/ImagePropertiesRecordLib.inf > > # > # CPU > diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > index 59577eda4f..67472930c9 100644 > --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > @@ -167,6 +167,7 @@ > !endif > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in > f > + > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordL > + ib/ImagePropertiesRecordLib.inf > > # > # CPU -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111931): https://edk2.groups.io/g/devel/message/111931 Mute This Topic: https://groups.io/mt/102906246/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
