[AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin <mike.maslen...@gmail.com> > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <abner.ch...@amd.com>; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin <mike.maslen...@gmail.com> > Subject: [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > StrnCpyS accepts string length in characters, not in bytes. > > Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> > --- > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > index 8ac165dec59e..c19d4a46d6af 100644 > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > @@ -331,7 +331,7 @@ NewInternalInstance ( > } > > > > NewInternalData->NodeName = AllocateZeroPool (StrSize (NodeName)); > > - StrnCpyS (NewInternalData->NodeName, StrSize (NodeName), (CONST > CHAR16 *)NodeName, StrLen (NodeName)); > > + StrnCpyS (NewInternalData->NodeName, StrLen (NodeName) + 1, (CONST > CHAR16 *)NodeName, StrLen (NodeName)); The original code is already the size of string that includes NULL terminator. However, we should check if NewInternalData->NodeName is NULL or not before copying the string. Mike, could you please help to add this check?
Thanks Abner > > NewInternalData->SiblingList = NULL; > > NewInternalData->ChildList = NULL; > > if (NodeIsCollection) { > > -- > 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109249): https://edk2.groups.io/g/devel/message/109249 Mute This Topic: https://groups.io/mt/101667469/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-