Hi Nickle, patch looks good to me. You can add my acked-by/reviewed-by if you wish.
Thanks, Mike. On Mon, Sep 18, 2023 at 4:15 PM Nickle Wang <nick...@nvidia.com> wrote: > > Hi Mike, > > Sorry for my late response. Version2 is here: > https://edk2.groups.io/g/devel/message/108778 Please help me to review it > while you have chance. > > Thanks, > Nickle > > > -----Original Message----- > > From: Mike Maslenkin <mike.maslen...@gmail.com> > > Sent: Thursday, August 3, 2023 6:16 PM > > To: Nickle Wang <nick...@nvidia.com> > > Cc: devel@edk2.groups.io; Abner Chang <abner.ch...@amd.com>; Igor > > Kulchytskyy <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> > > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP > > status code to caller. > > > > External email: Use caution opening links or attachments > > > > > > Yes. I suggest not to release ResponseMessage->Body > > > > There is a function RestConfigFreeHttpMessage releasing Message->Body as > > well > > as Message->Data.Response > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L134&data=05%7C01%7Cni > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UWjhhvnVOQAF6TwHrjD%2FUxq > > zvmKXviZDa%2FW6iyDZyC8%3D&reserved=0 > > > > called from: > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L555&data=05%7C01%7Cni > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4KQJiTuPrYeiLHpe0IL5mxTG04n > > m5W7nwPSPeE1MNoo%3D&reserved=0 > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L734&data=05%7C01%7Cni > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pPYswuNST%2BrOjNgSbfWVtGSF > > G4OV%2BuIiy69Pb1VlxHg%3D&reserved=0 > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L921&data=05%7C01%7Cni > > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l162YPCSVbXo%2Fz0tyC7WVK1Z > > I4rvIEU%2F%2FdX79E8w8mY%3D&reserved=0 > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F > > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L1080&data=05%7C01%7Cn > > icklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157 > > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL > > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w%2BsMb1C313iW3mAyd61r%2 > > BVKLUkHO5%2BfdROfdT6dkgUU%3D&reserved=0 > > > > So I guess RestConfigFreeHttpMessage() makes a proper resource deallocation > > otherwise patch introduces a memory leak for error handling path, for > > example > > here: > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe > > %2FRedfishRestExProtocol.c%23L429&data=05%7C01%7Cnicklew%40nvidia.com > > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c > > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > > 000%7C%7C%7C&sdata=kh65FknkTo6LcogwQ4fjIPjaFL6Cv6rv%2FtrO2njgxzg%3D > > &reserved=0 > > and > > https://github.co/ > > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe > > %2FRedfishRestExProtocol.c%23L364&data=05%7C01%7Cnicklew%40nvidia.com > > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c > > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ > > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > > 000%7C%7C%7C&sdata=Oa8dIM9YxGdtkM60HiwgpoOqKPT9YaJms%2BE3RIlZd% > > 2FE%3D&reserved=0 > > and so on. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108831): https://edk2.groups.io/g/devel/message/108831 Mute This Topic: https://groups.io/mt/100292372/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
