Sunil: I agree this is a critical bug fix. The fix is correct. CI failure is not related to this change. If no other comment, I will help merge this change tomorrow.
Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sunil V L > 发送时间: 2023年8月22日 14:26 > 收件人: devel@edk2.groups.io; Liming Gao <gaolim...@byosoft.com.cn> > 抄送: Li, Yong <yong...@intel.com>; 2931013...@sjtu.edu.cn; Warkentin, > Andrei <andrei.warken...@intel.com> > 主题: Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore > Blockmap config > > Hi Liming, > > This is a bug fix and can cause data loss if the variable size > 4k. > Can it be included for the edk2-stable202308? Let me know if it requires > a BZ id. > > I tried running the CI tests for this patch. But 2 of tests failed and I > don't think it has anything to do with this patch. If you are ok to take > this patch for the stable release, could you please let me know what > needs to be done? > > PR : https://github.com/tianocore/edk2/pull/4754 > > Thanks! > Sunil > > On Wed, Aug 16, 2023 at 02:33:00PM +0530, Sunil V L via groups.io wrote: > > On Wed, Aug 16, 2023 at 07:08:58AM +0000, Li, Yong wrote: > > > Hi Sunil, > > > > > > Qingyu is from Penglai team, when we were working together in enabling > StandaloneMm variable service, > > > we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which the > blockmap config is not aligned with the value in > > > > OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c, > which is SIZE_256KB > > > > > > That mis-alignment won't cause any issue if the variable size is small and > less than 0x1000, but if store more data in the flash device then it will cause > data loss issue during reboot. > > > Once reboot if any FV header data is corrupted it will result the whole > variable system be re-initialized. > > > > > > Please help review the patch and give the comments, thanks > > > > > Hi Yong Li, > > > > Thank you very much for providing the context. Sorry, I actually had > > missed this. > > > > Hi Quingyu Shang, > > > > The patch LGTM. Thanks a lot for finding the issue and fixing it. In > > future, could you please run BaseTools/Scripts/GetMaintainer.py on the > > patches and CC all the people it lists using "Cc:" tag? > > > > Reviewed-by: Sunil V L <suni...@ventanamicro.com> > > > > Thanks! > > Sunil > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107992): https://edk2.groups.io/g/devel/message/107992 Mute This Topic: https://groups.io/mt/100928325/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
