Hi Sunil, Happy you like that! I will CC all the related maintainers by that python script next time.
Thanks! Qingyu -----原始邮件----- 发件人: "Sunil V L" <suni...@ventanamicro.com> 收件人: "Li, Yong" <yong...@intel.com> 抄送: devel@edk2.groups.io, 2931013...@sjtu.edu.cn, "Warkentin, Andrei" <andrei.warken...@intel.com> 已发送邮件: 星期三, 8 月 16, 2023 05:03:00 PM 主题: Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config On Wed, Aug 16, 2023 at 07:08:58AM +0000, Li, Yong wrote: > Hi Sunil, > > Qingyu is from Penglai team, when we were working together in enabling > StandaloneMm variable service, > we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which the > blockmap config is not aligned with the value in > OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c, > which is SIZE_256KB > > That mis-alignment won't cause any issue if the variable size is small and > less than 0x1000, but if store more data in the flash device then it will > cause data loss issue during reboot. > Once reboot if any FV header data is corrupted it will result the whole > variable system be re-initialized. > > Please help review the patch and give the comments, thanks > Hi Yong Li, Thank you very much for providing the context. Sorry, I actually had missed this. Hi Quingyu Shang, The patch LGTM. Thanks a lot for finding the issue and fixing it. In future, could you please run BaseTools/Scripts/GetMaintainer.py on the patches and CC all the people it lists using "Cc:" tag? Reviewed-by: Sunil V L <suni...@ventanamicro.com> Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107795): https://edk2.groups.io/g/devel/message/107795 Mute This Topic: https://groups.io/mt/100776646/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
