I'm not sure why test results are not being reported that may be a
larger issue.
I pulled the branch locally, run uncrustify, and it automatically fixed
the code to pass.
The issue is the following function call:
BuildPlatformInfoHob();
Should be:
BuildPlatformInfoHob ();
On 8/10/2023 11:46 AM, Ard Biesheuvel wrote:
Could someone please decipher this for us please? I am sick and tired
of the CI impeding my work.
On Thu, 10 Aug 2023 at 15:33, Corvin Köhne <corv...@freebsd.org> wrote:
On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote:
On Thu, 10 Aug 2023 at 14:53, Corvin Köhne <corv...@freebsd.org>
wrote:
On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote:
On Tue, 8 Aug 2023 at 15:33, Rebecca Cran <rebe...@bsdio.com>
wrote:
Nit: "sizeof" is normally used like a function. And this patch
mixes the
two styles.
Actually, this is not unidiomatic for OVMF - sizeof takes either
a
type name (in which case the () are required) or an expression
(in
which case they are optional), and we have always permitted both
idioms for the latter case.
$ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/
OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4
OvmfPkg/EnrollDefaultKeys/AuthData.c:4
OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupp
ort.
c:7
OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c
:1
OvmfPkg/PlatformPei/MemTypeInfo.c:1
OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5
OvmfPkg/QemuVideoDxe/VbeShim.c:4
OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4
OvmfPkg/Virtio10Dxe/Virtio10.c:1
OvmfPkg/VirtioGpuDxe/DriverBinding.c:4
Other than that:
Reviewed-by: Rebecca Cran <rebe...@bsdio.com>
Thanks
I've tried to merge this but I am getting errors and I cannot
figure
out what they are:
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=99505&view=results
Thanks. Have you tried
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
I'm stuck at step 5. I can't see something like "92.5% passed".
Maybe I
don't have the permission to see it?
I was having the same problem. The instructions don't match the
actual
situation, so it is impossible for me to figure why the CI decided to
reject the series.
The function is copied from OvmfPkg/PlatformPei. So, it's unlikely that
it causes issues. Nevertheless, I found a candidate:
diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c
b/OvmfPkg/Bhyve/PlatformPei/Platform.c
index 5bfe435327c1..bdfc1614d284 100644
--- a/OvmfPkg/Bhyve/PlatformPei/Platform.c
+++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c
@@ -17,6 +17,7 @@
//
// The Library classes this module consumes
//
+#include <Library/BaseMemoryLib.h>
#include <Library/BaseLib.h>
This is not in alphabetical order.
#include <Library/DebugLib.h>
#include <Library/HobLib.h>
--
Kind regards,
Corvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107701): https://edk2.groups.io/g/devel/message/107701
Mute This Topic: https://groups.io/mt/100327419/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
