Thanks for the patch, inline comment below:
> -----Original Message----- > From: Giri Mudusuru <gi...@apple.com> > Sent: Friday, May 12, 2023 5:55 PM > To: devel@edk2.groups.io > Cc: Giri Mudusuru <gi...@apple.com>; Wu, Hao A <hao.a...@intel.com>; Ni, > Ray <ray...@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Andrew Fish <af...@apple.com> > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug > print is incorrect > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394 > > Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit > pointer > > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Andrew Fish <af...@apple.com> > Signed-off-by: Giri Mudusuru <gi...@apple.com> > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > index aab6815328..2e7497a89d 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > @@ -30,7 +30,7 @@ DumpCapabilityReg ( > // > > // Dump Capability Data > > // > > - DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot, > Capability)); > > + DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot, > *(UINT64 *)Capability)); Please help to use %p for printing pointers. Best Regards, Hao Wu > > DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability- > >TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); > > DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability- > >BaseClkFreq)); > > DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << > Capability->MaxBlkLen))); > > -- > 2.39.2 (Apple Git-144) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104959): https://edk2.groups.io/g/devel/message/104959 Mute This Topic: https://groups.io/mt/98846217/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
