Sure, can track this one.
-----Original Message-----
From: Kinney, Michael D <michael.d.kin...@intel.com>
Sent: Thursday, May 11, 2023 5:22 AM
To: Guo, Gua <gua....@intel.com>; devel@edk2.groups.io;
quic_llind...@quicinc.com
Cc: Hsu, VictorX <victorx....@intel.com>; Chiu, Chasel <chasel.c...@intel.com>;
Kinney, Michael D <michael.d.kin...@intel.com>
Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update reviewers and
maintainers for TraceHubDebugLib.
Hi Gua,
Can you please resend the email patches for the series and make sure the Author
and Signed-off-by are correct on your local branch before sending.
Thanks,
Mike
> -----Original Message-----
> From: Guo, Gua <gua....@intel.com>
> Sent: Wednesday, May 10, 2023 2:02 PM
> To: Kinney, Michael D <michael.d.kin...@intel.com>;
> devel@edk2.groups.io; quic_llind...@quicinc.com
> Cc: Hsu, VictorX <victorx....@intel.com>; Chiu, Chasel
> <chasel.c...@intel.com>
> Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update
> reviewers and maintainers for TraceHubDebugLib.
>
> @Leif Lindholm and @Kinney, Michael D
>
> I've locate Leif and update on the PR.
>
> - Split submodule into new patch
> - Fix formatting issue
> - Add Review-by message
> - Offline check with Victor to use my sign-off name.
> https://github.com/tianocore/edk2/pull/3901
>
> Thanks,
> Gua
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kin...@intel.com>
> Sent: Thursday, May 11, 2023 2:57 AM
> To: devel@edk2.groups.io; quic_llind...@quicinc.com; Guo, Gua
> <gua....@intel.com>
> Cc: Hsu, VictorX <victorx....@intel.com>; Kinney, Michael D
> <michael.d.kin...@intel.com>
> Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update
> reviewers and maintainers for TraceHubDebugLib.
>
> Hi Leif,
>
> The original patch series was sent by Victor in January and has
> Signed-off-by from Victor.
>
> https://edk2.groups.io/g/devel/message/99333
>
> Subsequent updates to the patch series based on feedback were sent by Gua.
>
> With this background, who should be Signed-off-by and the Author in
> the final patch series?
>
> Mike
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif
> > Lindholm
> > Sent: Wednesday, May 10, 2023 11:34 AM
> > To: devel@edk2.groups.io; Guo, Gua <gua....@intel.com>
> > Cc: Hsu, VictorX <victorx....@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update
> > reviewers and maintainers for TraceHubDebugLib.
> >
> > On Wed, May 10, 2023 at 10:33:55 +0800, Guo, Gua wrote:
> > > From: Gua Guo <gua....@intel.com>
> > >
> > > Update reviewers and maintainers for TraceHubDebugSysTlib.
> > >
> > > Signed-off-by: VictorX Hsu <victorx....@intel.com>
> >
> > The DCO is a legal statement about the contribution. Only the person
> > posting the patches can make that statement.
> > If VictorX is the author, that should be covered by the From: tag.
> > I notice this applies to the whole set. Please address.
> >
> > Once addressed:
> > Reviewed-by: Leif Lindholm <quic_llind...@quicinc.com>
> >
> > /
> > Leif
> >
> > > ---
> > > Maintainers.txt | 18 ++++++++++++++++++
> > > 1 file changed, 18 insertions(+)
> > >
> > > diff --git a/Maintainers.txt b/Maintainers.txt index
> > > 09d04af27a..30e2d2686d 100644
> > > --- a/Maintainers.txt
> > > +++ b/Maintainers.txt
> > > @@ -437,6 +437,14 @@ R: Zhiguang Liu <zhiguang....@intel.com>
> > [LiuZhiguang001]
> > > R: Ray Ni <ray...@intel.com> [niruiyu]
> > > R: Gua Guo <gua....@intel.com> [gguo11837463]
> > >
> > > +MdeModulePkg: Trace Hub debug message related library instance
> > > +F: MdeModulePkg/Library/TraceHubDebugSysTLib/
> > > +F: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
> > > +M: Gua Guo <gua....@intel.com> [gguo11837463]
> > > +M: Prakashan Krishnadas Veliyathuparambil
> > <krishnadas.veliyathuparambil.prakas...@intel.com> [kprakas2]
> > > +R: Chan Laura <laura.c...@intel.com> [lauracha]
> > > +R: K N Karthik <karthik....@intel.com> [karthikkabbigere1]
> > > +
> > > MdePkg
> > > F: MdePkg/
> > > W: https://github.com/tianocore/tianocore.github.io/wiki/MdePkg
> > > @@ -444,6 +452,16 @@ M: Michael D Kinney
> > > <michael.d.kin...@intel.com>
> > [mdkinney]
> > > M: Liming Gao <gaolim...@byosoft.com.cn> [lgao4]
> > > R: Zhiguang Liu <zhiguang....@intel.com> [LiuZhiguang001]
> > >
> > > +MdePkg: Trace Hub debug message related library instance
> > > +F: MdePkg/Library/TraceHubDebugSysTLibNull/
> > > +F: MdePkg/Library/MipiSysTLib/
> > > +F: MdePkg/Include/Library/TraceHubDebugSysTLib.h
> > > +F: MdePkg/Include/Library/MipiSysTLib.h
> > > +M: Gua Guo <gua....@intel.com> [gguo11837463]
> > > +M: Prakashan Krishnadas Veliyathuparambil
> > <krishnadas.veliyathuparambil.prakas...@intel.com> [kprakas2]
> > > +R: Chan Laura <laura.c...@intel.com> [lauracha]
> > > +R: K N Karthik <karthik....@intel.com> [karthikkabbigere1]
> > > +
> > > NetworkPkg
> > > F: NetworkPkg/
> > > W:
> > > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
> > > --
> > > 2.39.2.windows.1
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104616): https://edk2.groups.io/g/devel/message/104616
Mute This Topic: https://groups.io/mt/98798695/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
--- Begin Message ---
From: Gua Guo <gua....@intel.com>
V7: Miss one patch on V6
V6:
- https://github.com/tianocore/edk2/pull/3901
Split submodule into new patch
Fix formatting issue
Add Review-by message
Offline check with Victor to use my sign-off name.
V5: if no other open, it will be final change
- https://github.com/tianocore/edk2/pull/3901
Fix random exception when long run catalog debug message
V4
- https://github.com/tianocore/edk2/pull/3901 - Done
Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make implement
code more simple.
V3
- https://github.com/tianocore/edk2/pull/3901 - Done
- Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why
MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5?
Solution: Remove this macro, use Library Constructor to allocate it
dynamiclly.
- Open:
MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c:
SwapBytesGuid () algorithm wrong.
Solution: Follow correct algorithm to implement it.
VOID
EFIAPI
SwapBytesGuid (
IN GUID *Guid, <----------- In PreMem, guid is global data
so region is readonly, add output data to support it.
OUT GUID *ConvertedGuid
);
- Open: Merge MSFT and GCC CC_FLAGS as they both supports -D
Solution: use *_*_*_CC_FLAGS = -DMIPI_SYST_STATIC to unified both.
V2
- https://github.com/tianocore/edk2/pull/3901
- Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why
MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5?
- Open:
MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c:
SwapBytesGuid () algorithm wrong.
- Open: Merge MSFT and GCC CC_FLAGS as they both supports -D
V1
Previous PR:
- https://github.com/tianocore/edk2/pull/3613
- TraceHubDebugLib without submodule - Reject
- https://github.com/tianocore/edk2/pull/3793
- TraceHubDebugLib with submodule and without seperate into MipiSysTLib and
TraceHubDebugLib - Reject
Gua Guo (5):
MdePkg: Add mipisyst submodule
MdePkg: Add MipiSysTLib library
MdePkg: Add NULL library of TraceHubDebugSysTLib
MdeModulePkg: Add TraceHubDebugSysTLib library
Maintainers.txt: Update reviewers and maintainers for
TraceHubDebugLib.
.gitmodules | 3 +
.pytool/CISettings.py | 2 +
Maintainers.txt | 18 +
.../Include/Guid/TraceHubDebugInfoHob.h | 24 +
.../BaseTraceHubDebugSysTLib.c | 245 ++++++
.../BaseTraceHubDebugSysTLib.inf | 44 +
.../DxeSmmTraceHubDebugSysTLib.c | 263 ++++++
.../DxeSmmTraceHubDebugSysTLib.inf | 51 ++
.../InternalTraceHubApi.c | 74 ++
.../InternalTraceHubApi.h | 37 +
.../InternalTraceHubApiCommon.c | 200 +++++
.../InternalTraceHubApiCommon.h | 119 +++
.../PeiTraceHubDebugSysTLib.c | 282 +++++++
.../PeiTraceHubDebugSysTLib.inf | 50 ++
.../Library/TraceHubDebugSysTLib/Readme.md | 26 +
MdeModulePkg/MdeModulePkg.dec | 21 +
MdeModulePkg/MdeModulePkg.dsc | 3 +
MdeModulePkg/MdeModulePkg.uni | 18 +
MdePkg/Include/Library/MipiSysTLib.h | 66 ++
MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++
MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++
MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++
MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 52 ++
MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++
MdePkg/Library/MipiSysTLib/Platform.h | 138 +++
MdePkg/Library/MipiSysTLib/Readme.md | 25 +
MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 ++++++++++++++++++
MdePkg/Library/MipiSysTLib/mipisyst | 1 +
.../TraceHubDebugSysTLibNull.c | 76 ++
.../TraceHubDebugSysTLibNull.inf | 29 +
MdePkg/MdePkg.ci.yaml | 12 +-
MdePkg/MdePkg.dec | 9 +
MdePkg/MdePkg.dsc | 2 +
ReadMe.rst | 1 +
34 files changed, 3177 insertions(+), 3 deletions(-)
create mode 100644 MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.inf
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.c
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.inf
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.h
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c
create mode 100644
MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.inf
create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md
create mode 100644 MdePkg/Include/Library/MipiSysTLib.h
create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h
create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py
create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c
create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf
create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c
create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h
create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md
create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h
create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst
create mode 100644
MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c
create mode 100644
MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf
--
2.39.2.windows.1
--- End Message ---
