Hi Gua, Can you please resend the email patches for the series and make sure the Author and Signed-off-by are correct on your local branch before sending.
Thanks, Mike > -----Original Message----- > From: Guo, Gua <gua....@intel.com> > Sent: Wednesday, May 10, 2023 2:02 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; devel@edk2.groups.io; > quic_llind...@quicinc.com > Cc: Hsu, VictorX <victorx....@intel.com>; Chiu, Chasel > <chasel.c...@intel.com> > Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update reviewers > and maintainers for TraceHubDebugLib. > > @Leif Lindholm and @Kinney, Michael D > > I've locate Leif and update on the PR. > > - Split submodule into new patch > - Fix formatting issue > - Add Review-by message > - Offline check with Victor to use my sign-off name. > https://github.com/tianocore/edk2/pull/3901 > > Thanks, > Gua > -----Original Message----- > From: Kinney, Michael D <michael.d.kin...@intel.com> > Sent: Thursday, May 11, 2023 2:57 AM > To: devel@edk2.groups.io; quic_llind...@quicinc.com; Guo, Gua > <gua....@intel.com> > Cc: Hsu, VictorX <victorx....@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com> > Subject: RE: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update reviewers > and maintainers for TraceHubDebugLib. > > Hi Leif, > > The original patch series was sent by Victor in January and has Signed-off-by > from Victor. > > https://edk2.groups.io/g/devel/message/99333 > > Subsequent updates to the patch series based on feedback were sent by Gua. > > With this background, who should be Signed-off-by and the Author in the > final patch series? > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Leif > > Lindholm > > Sent: Wednesday, May 10, 2023 11:34 AM > > To: devel@edk2.groups.io; Guo, Gua <gua....@intel.com> > > Cc: Hsu, VictorX <victorx....@intel.com> > > Subject: Re: [edk2-devel] [PATCH v3 4/4] Maintainers.txt: Update > > reviewers and maintainers for TraceHubDebugLib. > > > > On Wed, May 10, 2023 at 10:33:55 +0800, Guo, Gua wrote: > > > From: Gua Guo <gua....@intel.com> > > > > > > Update reviewers and maintainers for TraceHubDebugSysTlib. > > > > > > Signed-off-by: VictorX Hsu <victorx....@intel.com> > > > > The DCO is a legal statement about the contribution. Only the person > > posting the patches can make that statement. > > If VictorX is the author, that should be covered by the From: tag. > > I notice this applies to the whole set. Please address. > > > > Once addressed: > > Reviewed-by: Leif Lindholm <quic_llind...@quicinc.com> > > > > / > > Leif > > > > > --- > > > Maintainers.txt | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > > 09d04af27a..30e2d2686d 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -437,6 +437,14 @@ R: Zhiguang Liu <zhiguang....@intel.com> > > [LiuZhiguang001] > > > R: Ray Ni <ray...@intel.com> [niruiyu] > > > R: Gua Guo <gua....@intel.com> [gguo11837463] > > > > > > +MdeModulePkg: Trace Hub debug message related library instance > > > +F: MdeModulePkg/Library/TraceHubDebugSysTLib/ > > > +F: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > > > +M: Gua Guo <gua....@intel.com> [gguo11837463] > > > +M: Prakashan Krishnadas Veliyathuparambil > > <krishnadas.veliyathuparambil.prakas...@intel.com> [kprakas2] > > > +R: Chan Laura <laura.c...@intel.com> [lauracha] > > > +R: K N Karthik <karthik....@intel.com> [karthikkabbigere1] > > > + > > > MdePkg > > > F: MdePkg/ > > > W: https://github.com/tianocore/tianocore.github.io/wiki/MdePkg > > > @@ -444,6 +452,16 @@ M: Michael D Kinney > > > <michael.d.kin...@intel.com> > > [mdkinney] > > > M: Liming Gao <gaolim...@byosoft.com.cn> [lgao4] > > > R: Zhiguang Liu <zhiguang....@intel.com> [LiuZhiguang001] > > > > > > +MdePkg: Trace Hub debug message related library instance > > > +F: MdePkg/Library/TraceHubDebugSysTLibNull/ > > > +F: MdePkg/Library/MipiSysTLib/ > > > +F: MdePkg/Include/Library/TraceHubDebugSysTLib.h > > > +F: MdePkg/Include/Library/MipiSysTLib.h > > > +M: Gua Guo <gua....@intel.com> [gguo11837463] > > > +M: Prakashan Krishnadas Veliyathuparambil > > <krishnadas.veliyathuparambil.prakas...@intel.com> [kprakas2] > > > +R: Chan Laura <laura.c...@intel.com> [lauracha] > > > +R: K N Karthik <karthik....@intel.com> [karthikkabbigere1] > > > + > > > NetworkPkg > > > F: NetworkPkg/ > > > W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg > > > -- > > > 2.39.2.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104604): https://edk2.groups.io/g/devel/message/104604 Mute This Topic: https://groups.io/mt/98798695/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
