Hi Wang, Thanks for this point, you're right. It's a redundant change and I will update in v2 patches, but the second change is necessary. How do you think about that?
Thanks, Minh Nguyen -----Original Message----- From: Nickle Wang <[email protected]> Sent: Friday, April 14, 2023 4:04 PM To: Minh Nguyen OS <[email protected]>; [email protected] Cc: Open Source Submission <[email protected]>; [email protected]; [email protected]; Nhi Pham OS <[email protected]>; Tinh Nguyen OS <[email protected]>; Vu Nguyen OS <[email protected]> Subject: RE: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero length region Hi Minh, > Prevent assertion of allocate zero length region May I know where does zero length allocation happen? According to my understanding, setting the "SubnetAddrInfoIPv6Number" to zero here and it will be handled by below condition check: https://github.com/tianocore/edk2/blob/55b67b6950e648338adfe8ec54aeb26ed89d2c97/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c#L1005 Then the code leaves function with EFI_NOT_FOUND error. Thanks, Nickle > -----Original Message----- > From: Minh Nguyen <[email protected]> > Sent: Friday, April 14, 2023 4:19 PM > To: [email protected] > Cc: [email protected]; [email protected]; Nickle Wang > <[email protected]>; [email protected]; [email protected]; > [email protected]; Vu Nguyen > <[email protected]>; Minh Nguyen > <[email protected]> > Subject: [PATCH 2/5] RedfishPkg: Prevent assertion of allocate zero > length region > > External email: Use caution opening links or attachments > > > From: Vu Nguyen <[email protected]> > > This change also fix miscellaneous errors on condition checking and > debug argument missing. > > Signed-off-by: Minh Nguyen <[email protected]> > --- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 583c6f78e19c..29e7b0624ebf 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -5,6 +5,7 @@ > (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR> > Copyright (c) 2022, AMD Incorporated. All rights reserved. > Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. > + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -272,7 +273,7 @@ Tcp6GetSubnetInfo ( > if (IpModedata.AddressCount == 0) { > DEBUG ((DEBUG_INFO, "%a: No IPv6 address configured.\n", __func__)); > Instance->SubnetAddrInfoIPv6Number = 0; > - return EFI_SUCCESS; > + return EFI_NOT_FOUND; > } > > if (Instance->SubnetAddrInfoIPv6 != NULL) { @@ -926,7 +927,7 @@ > AddAndSignalNewRedfishService ( > } > > Status = gBS->SignalEvent (Instance->DiscoverToken->Event); > - if (!EFI_ERROR (Status)) { > + if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__)); > } > } > -- > 2.39.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103115): https://edk2.groups.io/g/devel/message/103115 Mute This Topic: https://groups.io/mt/98258415/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
