[AMD Official Use Only - General]
Hi Abner,
I think EDK2 uses the below naming convention for variables which are
acronyms.
First letter is capitalized, and rest all are smaller.
Its better to rename below variables from <pre-string>I2C<post-string> to
<pre-string>I2c<post-string>.
-----Original Message-----
From: Chang, Abner <abner.ch...@amd.com>
Sent: Saturday, April 15, 2023 5:27 PM
To: devel@edk2.groups.io
Cc: Isaac Oram <isaac.w.o...@intel.com>; Attar, AbdulLateef (Abdul Lateef)
<abdullateef.at...@amd.com>; Nickle Wang <nick...@nvidia.com>; Tinh Nguyen
<tinhngu...@amperemail.onmicrosoft.com>
Subject: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of
I2C
From: Abner Chang <abner.ch...@amd.com>
Signed-off-by: Abner Chang <abner.ch...@amd.com>
Cc: Isaac Oram <isaac.w.o...@intel.com>
Cc: Abdul Lateef Attar <abdat...@amd.com>
Cc: Nickle Wang <nick...@nvidia.com>
Cc: Tinh Nguyen <tinhngu...@amperemail.onmicrosoft.com>
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +++++-----
.../BaseManageabilityTransportHelper.inf | 2 +-
.../BaseManageabilityTransportHelper.c | 14 +++++++-------
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
b/Features/ManageabilityPkg/ManageabilityPkg.dec
index 9a930d3e4b..3656190a70 100644
--- a/Features/ManageabilityPkg/ManageabilityPkg.dec
+++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
@@ -32,13 +32,13 @@
# Manageability Transport Interface type
#
# Manageability Transport KCS
- gManageabilityTransportKcsGuid = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA,
0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
- # Manageability Transport I2C
- gManageabilityTransportI2CGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0,
0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
Change to I2c
+ gManageabilityTransportKcsGuid = { 0x5A6E64E9, 0xFD47, 0x4086, { 0xAA,
0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } }
+ # Manageability Transport SMBUS I2C
+ gManageabilityTransportSmbusI2CGuid = { 0x5B174658, 0x8263, 0x4CB8, { 0xA0,
0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } }
Change to I2c
# Manageability Transport PCI VDM
- gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D,
0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
+ gManageabilityTransportPciVdmGuid = { 0x388021A7, 0xFB59, 0x4811, { 0x9D,
0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } }
# Manageability Transport MCTP
- gManageabilityTransportMctpGuid = { 0x6798448D, 0x1200, 0x4577, { 0x82,
0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
+ gManageabilityTransportMctpGuid = { 0x6798448D, 0x1200, 0x4577, { 0x82,
0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } }
# Manageability Protocol Specification
#
diff --git
a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
index 95c3362ddb..8876e36480 100644
---
a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
+++
b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.inf
@@ -32,7 +32,7 @@
[Guids]
gManageabilityTransportKcsGuid
- gManageabilityTransportI2CGuid
+ gManageabilityTransportSmbusI2CGuid
Change to I2c
gManageabilityTransportPciVdmGuid
gManageabilityTransportMctpGuid
gManageabilityProtocolIpmiGuid
diff --git
a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
index 81da209764..6454f32670 100644
---
a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
+++
b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c
@@ -15,13 +15,13 @@
// Make sure the global variables added here should be unchangable.
//
MANAGEABILITY_SPECIFICATION_NAME ManageabilitySpecNameTable[] = {
- { &gManageabilityTransportKcsGuid, L"KCS" },
- { &gManageabilityTransportI2CGuid, L"I2C" },
- { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
- { &gManageabilityTransportMctpGuid, L"MCTP" },
- { &gManageabilityProtocolIpmiGuid, L"IPMI" },
- { &gManageabilityProtocolMctpGuid, L"MCTP" },
- { &gManageabilityProtocolPldmGuid, L"PLDM" }
+ { &gManageabilityTransportKcsGuid, L"KCS" },
+ { &gManageabilityTransportSmbusI2CGuid, L"SMBUS I2C"},
Change to I2c
+ { &gManageabilityTransportPciVdmGuid, L"PCI VDM" },
+ { &gManageabilityTransportMctpGuid, L"MCTP" },
+ { &gManageabilityProtocolIpmiGuid, L"IPMI" },
+ { &gManageabilityProtocolMctpGuid, L"MCTP" },
+ { &gManageabilityProtocolPldmGuid, L"PLDM" }
};
UINT16 mManageabilitySpecNum = sizeof (ManageabilitySpecNameTable)/ sizeof
(MANAGEABILITY_SPECIFICATION_NAME);
--
2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103104): https://edk2.groups.io/g/devel/message/103104
Mute This Topic: https://groups.io/mt/98280327/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
