[AMD Official Use Only - General] Thanks for review comment, will update accordingly.
-----Original Message----- From: Ni, Ray <ray...@intel.com> Sent: 11 April 2023 13:21 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com> Cc: Grimes, Paul <paul.gri...@amd.com>; Kirkendall, Garrett <garrett.kirkend...@amd.com>; Chang, Abner <abner.ch...@amd.com>; Dong, Eric <eric.d...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Gerd Hoffmann <kra...@redhat.com> Subject: RE: [edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > + ## @libraryclass Provides functions for manipulating Smram savestate > registers. > + SmmSmramSaveSateLib|Include/Library/SmmSmramSaveStateLib.h 1. Can you please rename the lib class to MmSaveStateLib? So the lib can be potentially linked with standalone MM CPU driver. 2. Also the lib header file name can be "MmSaveStateLib.h". > +EFI_STATUS > +EFIAPI > +SmramSaveStateReadRegister ( 3. The API can be MmSaveStateReadRegister(). > + IN UINTN CpuIndex, > + IN EFI_SMM_SAVE_STATE_REGISTER Register, 4. "EFI_MM_SAVE_STATE_REGISTER" -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103107): https://edk2.groups.io/g/devel/message/103107 Mute This Topic: https://groups.io/mt/98172965/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
