I agree C related source files and scripts that generate C code would be included.
Some of BaseTools python scripts generate .c/.h files too, so don't want to exclude all .py. Perhaps just exclude __file__? Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > Sent: Tuesday, April 11, 2023 2:30 PM > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kin...@intel.com>; > Gao, Liming <gaolim...@byosoft.com.cn>; Feng, > Bob C <bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com> > Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to > check for __FUNCTION__ > > On 4/11/23 2:21 PM, Michael D Kinney wrote: > > Should use we os.path services to get the file extension? > > > > There are may other file types that this check should be excluded > > (e.g. .sh, .gitignore, .gitmodules, .uni). Should this check only > > apply to .c, .h. What about .C and .H and also the addition of unit > > tests that use c++ file extensions? > > __func__ is valid in C99 and C++11, so it should apply to .c, .h, .C, > .H, .cpp, .hpp etc. > > I was wondering if we might have shell scripts that generate code too, > for example OvmfPkg/QemuVideoDxe/VbeShim.sh, in which case we might only > want to exclude .py which would catch this change to PatchCheck.py. > > > -- > Rebecca Cran > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102860): https://edk2.groups.io/g/devel/message/102860 Mute This Topic: https://groups.io/mt/98117903/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
