On 4/11/23 2:21 PM, Michael D Kinney wrote:
Should use we os.path services to get the file extension?
There are may other file types that this check should be excluded
(e.g. .sh, .gitignore, .gitmodules, .uni). Should this check only
apply to .c, .h. What about .C and .H and also the addition of unit
tests that use c++ file extensions?
__func__ is valid in C99 and C++11, so it should apply to .c, .h, .C,
.H, .cpp, .hpp etc.
I was wondering if we might have shell scripts that generate code too,
for example OvmfPkg/QemuVideoDxe/VbeShim.sh, in which case we might only
want to exclude .py which would catch this change to PatchCheck.py.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102859): https://edk2.groups.io/g/devel/message/102859
Mute This Topic: https://groups.io/mt/98117903/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
