On 3/15/23 4:07 AM, Gerd Hoffmann wrote:
Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC
and BUILD_CXX) and using the standard name 'LDFLAGS' instead of
'LFLAGS'. This allows clang to be used by running
'make -C BaseTools CC=clang CXX=clang++'.
Hmm, not sure this is a good idea.  I suspect there was some reason to
use BUILD_CC instead of CC in the first place ...

It looks like the change to use BUILD_CC was introduced by Liming in:


    BaseTools GnuMakefile: Update GCC Flags to the specific one with BUILD_ prefix

    To avoid the conflict with the default GCC flag name, BUILD_ prefix is added.

    Cc: Giri P Mudusuru <giri.p.mudus...@intel.com>
    Cc: Yonghong Zhu <yonghong....@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.0
    Signed-off-by: Liming Gao <liming....@intel.com>
    Reviewed-by: Yonghong Zhu <yonghong....@intel.com>
    Reviewed-by: Giri P Mudusuru <giri.p.mudus...@intel.com>


I don't understand how that would help, and I'm wondering if it was perhaps the result of a misunderstanding.


--
Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101330): https://edk2.groups.io/g/devel/message/101330
Mute This Topic: https://groups.io/mt/97022154/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to