Combine the situation, I prefer the case by case handling to simplify the patch series purpose for the smbase pre-relocation support.
Thanks, Jiaxin > -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Friday, February 10, 2023 9:13 PM > To: Gerd Hoffmann <kra...@redhat.com> > Cc: Wu, Jiaxin <jiaxin...@intel.com>; devel@edk2.groups.io; Dong, Eric > <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek > <ler...@redhat.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Zimmer, > Vincent <vincent.zim...@intel.com> > Subject: RE: [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base > HOB Data > > Gerd, > Firstly, chunk idea allows to split the >64K hob to multiple one without using > domain knowledge, that means the split can happen in byte level. It will hurt > debuggability a lot: When I exam the HOB list during debugging, it's hard to > combine/group the chunk hobs with the same GUID into >64K big hobs. > > Secondly, Code-First process requires the code be created in edk2-staging > repo. > It means the code cannot be merged in edk2 trunk. > > I would like to collect more use cases for >64K hobs and > if more such hobs are needed from different domains (not just CPU), I will > consider to use the chunk idea. > > Thanks, > Ray > > > -----Original Message----- > > From: Gerd Hoffmann <kra...@redhat.com> > > Sent: Friday, February 10, 2023 8:32 PM > > To: Ni, Ray <ray...@intel.com> > > Cc: Wu, Jiaxin <jiaxin...@intel.com>; devel@edk2.groups.io; Dong, Eric > > <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com>; Laszlo Ersek > > <ler...@redhat.com>; Kumar, Rahul R <rahul.r.ku...@intel.com> > > Subject: Re: [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base > HOB > > Data > > > > On Fri, Feb 10, 2023 at 11:56:01AM +0000, Ni, Ray wrote: > > > Gerd, > > > That requires changing PI spec > > > > Yes, but we have > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First- > > Process > > > > > and all HOB consuming logic. > > > > There is no need to change the existing logic. Code to handle > > chunked HOBs can go to new helper functions in HobLib. > > > > take care, > > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100050): https://edk2.groups.io/g/devel/message/100050 Mute This Topic: https://groups.io/mt/96871372/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
