Quoting Rebecca Cran (2023-01-20 22:22:55)
> Related to this, I've been wondering if we might want to commit a .vscode 
> directory with project configuration file(s)?

As long as project settings for other IDEs (should
there be a reasonable user base) would be accepted in the future, why not?

>
> Also perhaps a .editorconfig file?
I like the idea, because it is understood by many IDEs and text editors.

>
> --
>
> Rebecca Cran
>
>
> On 1/20/23 13:51, Michael Kubacki wrote:
>
>     From: Michael Kubacki [1]<michael.kuba...@microsoft.com>
>
>     Tianocore maintains container images in the tianocore/containers repo
>     and stores container images within the GitHub container registry.
>
>     [2]https://github.com/tianocore/containers
>
>     This change adds a devcontainer.json file to the edk2 repo. This
>     file's metadata and settings to configurate a development container
>     for a given well-defined tool and runtime stack.
>
>     More information about the devcontainer.json file is available here:
>     [3]https://containers.dev/implementors/json_reference/
>
>     This file is recognized by popular tools such as GitHub Codespaces
>     and VS Code. In VS Code in particular, it makes it much easier for
>     a user to be aware a dev container exists (via UI notifications)
>     and to load the container.
>
>     A minimal number of VS Code extensions are specified that are useful
>     for edk2 development or to assist in complying with CI checks in
>     place in edk2.
>
>     Cc: Andrew Fish [4]<af...@apple.com>
>     Cc: Chris Fernald [5]<chris.fern...@outlook.com>
>     Cc: Leif Lindholm [6]<quic_llind...@quicinc.com>
>     Cc: Michael D Kinney [7]<michael.d.kin...@intel.com>
>     Cc: Oliver Steffen [8]<ostef...@redhat.com>
>     Signed-off-by: Michael Kubacki [9]<michael.kuba...@microsoft.com>
>     ---
>      .devcontainer/devcontainer.json | 16 ++++++++++++++++
>      Maintainers.txt                 |  5 +++++
>      2 files changed, 21 insertions(+)
>
>     diff --git a/.devcontainer/devcontainer.json 
> b/.devcontainer/devcontainer.json
>     new file mode 100644
>     index 000000000000..592bb8cf6626
>     --- /dev/null
>     +++ b/.devcontainer/devcontainer.json
>     @@ -0,0 +1,16 @@
>     +{
>     +  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
>     +  "postCreateCommand": "git config --global --add safe.directory * && 
> pip install --upgrade -r pip-requirements.txt",
>     +  "customizations": {
>     +    "vscode": {
>     +      "extensions": [
>     +        "DavidAnson.vscode-markdownlint",
>     +        "ms-azuretools.vscode-docker",
>     +        "ms-vscode-remote.remote-containers",
>     +        "ms-vscode.cpptools",
>     +        "walonli.edk2-vscode",
>     +        "zachflower.uncrustify"
>     +      ]
>     +    }
>     +  }
>     +}
>     diff --git a/Maintainers.txt b/Maintainers.txt
>     index 68f603b48398..4aa7973d5156 100644
>     --- a/Maintainers.txt
>     +++ b/Maintainers.txt
>     @@ -117,6 +117,11 @@ M: Michael Kubacki 
> [10]<mikub...@linux.microsoft.com> [makubacki]
>      R: Michael D Kinney [11]<michael.d.kin...@intel.com> [mdkinney]
>      R: Liming Gao [12]<gaolim...@byosoft.com.cn> [lgao4]
>
>     +.devcontainer/
>     +F: .devcontainer/
>     +M: Michael Kubacki [13]<mikub...@linux.microsoft.com> [makubacki]
>     +R: Chris Fernald [14]<chris.fern...@outlook.com> [cfernald]
>     +
>      .github/
>      F: .github/
>      M: Sean Brogan [15]<sean.bro...@microsoft.com> [spbrogan]
>
>
-Oliver



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98959): https://edk2.groups.io/g/devel/message/98959
Mute This Topic: https://groups.io/mt/96409896/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to