Related to this, I've been wondering if we might want to commit a .vscode
directory with project configuration file(s)?
Also perhaps a .editorconfig file?
--
Rebecca Cran
On 1/20/23 13:51, Michael Kubacki wrote:
From: Michael Kubacki<[email protected]>
Tianocore maintains container images in the tianocore/containers repo
and stores container images within the GitHub container registry.
https://github.com/tianocore/containers
This change adds a devcontainer.json file to the edk2 repo. This
file's metadata and settings to configurate a development container
for a given well-defined tool and runtime stack.
More information about the devcontainer.json file is available here:
https://containers.dev/implementors/json_reference/
This file is recognized by popular tools such as GitHub Codespaces
and VS Code. In VS Code in particular, it makes it much easier for
a user to be aware a dev container exists (via UI notifications)
and to load the container.
A minimal number of VS Code extensions are specified that are useful
for edk2 development or to assist in complying with CI checks in
place in edk2.
Cc: Andrew Fish<[email protected]>
Cc: Chris Fernald<[email protected]>
Cc: Leif Lindholm<[email protected]>
Cc: Michael D Kinney<[email protected]>
Cc: Oliver Steffen<[email protected]>
Signed-off-by: Michael Kubacki<[email protected]>
---
.devcontainer/devcontainer.json | 16 ++++++++++++++++
Maintainers.txt | 5 +++++
2 files changed, 21 insertions(+)
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
new file mode 100644
index 000000000000..592bb8cf6626
--- /dev/null
+++ b/.devcontainer/devcontainer.json
@@ -0,0 +1,16 @@
+{
+ "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
+ "postCreateCommand": "git config --global --add safe.directory * && pip install
--upgrade -r pip-requirements.txt",
+ "customizations": {
+ "vscode": {
+ "extensions": [
+ "DavidAnson.vscode-markdownlint",
+ "ms-azuretools.vscode-docker",
+ "ms-vscode-remote.remote-containers",
+ "ms-vscode.cpptools",
+ "walonli.edk2-vscode",
+ "zachflower.uncrustify"
+ ]
+ }
+ }
+}
diff --git a/Maintainers.txt b/Maintainers.txt
index 68f603b48398..4aa7973d5156 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -117,6 +117,11 @@ M: Michael Kubacki<[email protected]>
[makubacki]
R: Michael D Kinney<[email protected]> [mdkinney]
R: Liming Gao<[email protected]> [lgao4]
+.devcontainer/
+F: .devcontainer/
+M: Michael Kubacki<[email protected]> [makubacki]
+R: Chris Fernald<[email protected]> [cfernald]
+
.github/
F: .github/
M: Sean Brogan<[email protected]> [spbrogan]
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98942): https://edk2.groups.io/g/devel/message/98942
Mute This Topic: https://groups.io/mt/96409896/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
