Thanks Gerd, I will refine the code logic.

> -----Original Message-----
> From: Gerd Hoffmann <[email protected]>
> Sent: Friday, January 13, 2023 5:51 PM
> To: Wu, Jiaxin <[email protected]>
> Cc: [email protected]; Dong, Eric <[email protected]>; Ni, Ray
> <[email protected]>; Zeng, Star <[email protected]>; Laszlo Ersek
> <[email protected]>; Kumar, Rahul R <[email protected]>
> Subject: Re: [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM
> Base Hob for SmBase info
> 
>   Hi,
> 
> > +  } else {
> > +    mSmmInitialized = (BOOLEAN *)AllocateZeroPool (sizeof (BOOLEAN) *
> mMaxNumberOfCpus);
> > +    ASSERT (mSmmInitialized != NULL);
> 
> ASSERT is not sufficient error handling.
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98467): https://edk2.groups.io/g/devel/message/98467
Mute This Topic: https://groups.io/mt/96241702/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to