Hi Mike, On 1/5/23 00:34, Kinney, Michael D wrote: > Hi Laszlo, > > Unit test code coverage was enabled just a couple days ago in CI. Looks like > you uncovered a corner case that was missed that should not generate a CI > failure. > > I have asked Gua to investigate.
the CI env is healthy, as far as I can tell. It's just that this patch catches a grave bug in QEMU, and refuses continue booting if the bug is present (intentionally). The issue is that currently there's no released QEMU version with the fix, so if this patch is merged immediately into OVMF, then OVMF will hang every test case in CI. (Every test scenario that boots OVMF one way or another.) Practically, this patch must be postponed until QEMU can be upgraded in the CI env -- it turns out though that the latter could be possible much earlier than I had hoped. Thanks! Laszlo > > Thanks, > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek >> Sent: Wednesday, January 4, 2023 7:13 AM >> To: devel@edk2.groups.io >> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>; Brijesh Singh >> <brijesh.si...@amd.com>; Aktas, Erdem <erdemak...@google.com>; Gerd >> Hoffmann <kra...@redhat.com>; James Bottomley <j...@linux.ibm.com>; Yao, >> Jiewen <jiewen....@intel.com>; Justen, Jordan L >> <jordan.l.jus...@intel.com>; Xu, Min M <min.m...@intel.com>; Boeuf, >> Sebastien <sebastien.bo...@intel.com>; Tom Lendacky >> <thomas.lenda...@amd.com> >> Subject: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU >> hotplug reg block regression >> >> Repo: https://pagure.io/lersek/edk2.git >> Branch: cpuhp-reg-catch-4250 >> Test build: https://github.com/tianocore/edk2/pull/3853 >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4250 >> >> NOTE: the test build linked above (in the github.com CI env) *failed*. >> That's because the CI environment is affected by this very QEMU bug! >> >> Namely, the following checks failed -- due to the intentional hang >> introduced in this patch: >> >> - PlatformCI_OvmfPkg_Ubuntu_GCC5_PR (12 tests) >> - PlatformCI_OvmfPkg_Windows_VS2019_PR (11 tests) >> >> (The Build_VS2019_TARGET_CODE_COVERAGE and >> Build_GCC5_TARGET_CODE_COVERAGE tests also failed, but those seem bogus >> to me.) >> >> All 12+11=23 PlatformCI_OvmfPkg_* checks failed due to timeout, and the >> firmware logs of the DEBUG and NOOPT builds end with: >> >>> INFO - PlatformMaxCpuCountInitialization: Broken CPU hotplug register >>> block: Present=0 Possible=1. >>> INFO - PlatformMaxCpuCountInitialization: Switch QEMU's acceleration from >>> TCG to KVM, or update QEMU. >>> INFO - PlatformMaxCpuCountInitialization: Refer to >>> <https://bugzilla.tianocore.org/show_bug.cgi?id=4250>. >>> INFO - ASSERT >>> /home/vsts/work/1/s/OvmfPkg/Library/PlatformInitLib/Platform.c(574): >>> ((BOOLEAN)(0==1)) >> >> So I'm not proposing to merge this immediately; something must be fixed >> first: >> >> - use KVM in the CI env, or >> >> - delay this patch until my QEMU fix is merged, and a new release is >> made, and the new QEMU release is packaged by the distros, and the new >> distro packages are picked up by github.com CI. >> >> Suggestions? >> >> Thanks, >> Laszlo >> >> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> >> Cc: Brijesh Singh <brijesh.si...@amd.com> >> Cc: Erdem Aktas <erdemak...@google.com> >> Cc: Gerd Hoffmann <kra...@redhat.com> >> Cc: James Bottomley <j...@linux.ibm.com> >> Cc: Jiewen Yao <jiewen....@intel.com> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Min Xu <min.m...@intel.com> >> Cc: Sebastien Boeuf <sebastien.bo...@intel.com> >> Cc: Tom Lendacky <thomas.lenda...@amd.com> >> >> Laszlo Ersek (1): >> OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression >> >> OvmfPkg/Library/PlatformInitLib/Platform.c | 34 ++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> >> >> >> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98002): https://edk2.groups.io/g/devel/message/98002 Mute This Topic: https://groups.io/mt/96051795/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
