@Kinney, Michael D<mailto:[email protected]> I create a PR to fix it. Could you help me for code review and push it to unlock the failure ? URL: https://github.com/tianocore/edk2/pull/3842/
-----Original Message----- From: Kinney, Michael D <[email protected]> Sent: Thursday, January 5, 2023 7:35 AM To: [email protected]; [email protected]; Guo, Gua <[email protected]> Cc: Ard Biesheuvel <[email protected]>; Brijesh Singh <[email protected]>; Aktas, Erdem <[email protected]>; Gerd Hoffmann <[email protected]>; James Bottomley <[email protected]>; Yao, Jiewen <[email protected]>; Justen, Jordan L <[email protected]>; Xu, Min M <[email protected]>; Boeuf, Sebastien <[email protected]>; Tom Lendacky <[email protected]>; Kinney, Michael D <[email protected]> Subject: RE: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression Hi Laszlo, Unit test code coverage was enabled just a couple days ago in CI. Looks like you uncovered a corner case that was missed that should not generate a CI failure. I have asked Gua to investigate. Thanks, Mike > -----Original Message----- > From: [email protected]<mailto:[email protected]> > <[email protected]<mailto:[email protected]>> On Behalf Of Laszlo > Ersek > Sent: Wednesday, January 4, 2023 7:13 AM > To: [email protected]<mailto:[email protected]> > Cc: Ard Biesheuvel > <[email protected]<mailto:[email protected]>>; Brijesh Singh > <[email protected]<mailto:[email protected]>>; Aktas, Erdem > <[email protected]<mailto:[email protected]>>; Gerd > Hoffmann <[email protected]<mailto:[email protected]>>; James Bottomley > <[email protected]<mailto:[email protected]>>; > Yao, Jiewen <[email protected]<mailto:[email protected]>>; Justen, > Jordan L > <[email protected]<mailto:[email protected]>>; Xu, Min M > <[email protected]<mailto:[email protected]>>; Boeuf, > Sebastien <[email protected]<mailto:[email protected]>>; Tom > Lendacky > <[email protected]<mailto:[email protected]>> > Subject: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch > QEMU's CPU hotplug reg block regression > > Repo: https://pagure.io/lersek/edk2.git > Branch: cpuhp-reg-catch-4250 > Test build: https://github.com/tianocore/edk2/pull/3853 > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4250 > > NOTE: the test build linked above (in the github.com CI env) *failed*. > That's because the CI environment is affected by this very QEMU bug! > > Namely, the following checks failed -- due to the intentional hang > introduced in this patch: > > - PlatformCI_OvmfPkg_Ubuntu_GCC5_PR (12 tests) > - PlatformCI_OvmfPkg_Windows_VS2019_PR (11 tests) > > (The Build_VS2019_TARGET_CODE_COVERAGE and > Build_GCC5_TARGET_CODE_COVERAGE tests also failed, but those seem > bogus to me.) > > All 12+11=23 PlatformCI_OvmfPkg_* checks failed due to timeout, and > the firmware logs of the DEBUG and NOOPT builds end with: > > > INFO - PlatformMaxCpuCountInitialization: Broken CPU hotplug register > > block: Present=0 Possible=1. > > INFO - PlatformMaxCpuCountInitialization: Switch QEMU's acceleration from > > TCG to KVM, or update QEMU. > > INFO - PlatformMaxCpuCountInitialization: Refer to > > <https://bugzilla.tianocore.org/show_bug.cgi?id=4250>. > > INFO - ASSERT > > /home/vsts/work/1/s/OvmfPkg/Library/PlatformInitLib/Platform.c(574): > > ((BOOLEAN)(0==1)) > > So I'm not proposing to merge this immediately; something must be > fixed > first: > > - use KVM in the CI env, or > > - delay this patch until my QEMU fix is merged, and a new release is > made, and the new QEMU release is packaged by the distros, and the new > distro packages are picked up by github.com CI. > > Suggestions? > > Thanks, > Laszlo > > Cc: Ard Biesheuvel > <[email protected]<mailto:[email protected]>> > Cc: Brijesh Singh <[email protected]<mailto:[email protected]>> > Cc: Erdem Aktas <[email protected]<mailto:[email protected]>> > Cc: Gerd Hoffmann <[email protected]<mailto:[email protected]>> > Cc: James Bottomley <[email protected]<mailto:[email protected]>> > Cc: Jiewen Yao <[email protected]<mailto:[email protected]>> > Cc: Jordan Justen > <[email protected]<mailto:[email protected]>> > Cc: Min Xu <[email protected]<mailto:[email protected]>> > Cc: Sebastien Boeuf > <[email protected]<mailto:[email protected]>> > Cc: Tom Lendacky <[email protected]<mailto:[email protected]>> > > Laszlo Ersek (1): > OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block > regression > > OvmfPkg/Library/PlatformInitLib/Platform.c | 34 ++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97968): https://edk2.groups.io/g/devel/message/97968 Mute This Topic: https://groups.io/mt/96051795/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
