On Wed, 28 Sept 2022 at 17:33, Dionna Glaze <dionnagl...@google.com> wrote: > > The default value of PcdEnableUnacceptedMemory should be FALSE in order > for default safe behavior. If the next started image does not yet > understand UEFI v2.9's new memory type, then it's stuck with most of its > memory inaccessible. > > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: James Bottomley <j...@linux.ibm.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Cc: Ard Biesheuvel <a...@kernel.org> > > Signed-off-by: Dionna Glaze <dionnagl...@google.com>
Generally, we tend to rely on the DEC default for new PCDs if we're not deviating from it. If there is no specific reason to deviate from this here, I think we can drop this patch. Or is this also needed to declare them as the right type? In that case, I think you can drop the hunks that touch non-CC platforms. > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/Bhyve/BhyveX64.dsc | 2 ++ > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 ++ > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 2 ++ > OvmfPkg/OvmfXen.dsc | 2 ++ > 7 files changed, 13 insertions(+) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 90e8a213ef..23086748c5 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -526,6 +526,7 @@ > > # Set ConfidentialComputing defaults > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0 > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableUnacceptedMemory|FALSE > > !include OvmfPkg/OvmfTpmPcds.dsc.inc > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index 475b88b21a..004be8b019 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -559,6 +559,8 @@ > # Set Tdx shared bit mask > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableUnacceptedMemory|FALSE > + > gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy|0x00 > > # MdeModulePkg resolution sets up the system display resolution > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.dsc > index 10b16104ac..41f43a2631 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -618,6 +618,8 @@ > # Set Tdx shared bit mask > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableUnacceptedMemory|FALSE > + > # Set SEV-ES defaults > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0 > diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > index c0c1a15b09..55b6a2a845 100644 > --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc > +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc > @@ -514,6 +514,8 @@ > # Set Tdx shared bit mask > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableUnacceptedMemory|FALSE > + > # Set SEV-ES defaults > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0 > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index af566b953f..aebe1c3192 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -655,6 +655,8 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdPteMemoryEncryptionAddressOrMask|0x0 > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableUnacceptedMemory|FALSE > + > # Set SEV-ES defaults > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0 > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index f39d9cd117..6e4418388e 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -679,6 +679,8 @@ > # Set Tdx shared bit mask > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableUnacceptedMemory|FALSE > + > # Set SEV-ES defaults > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0 > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0 > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 58a7c97cdd..0f57e22a2b 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -505,6 +505,8 @@ > # Set Tdx shared bit mask > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0 > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableUnacceptedMemory|FALSE > + > gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy|0x00 > > > ################################################################################ > -- > 2.37.3.998.g577e59143f-goog > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94478): https://edk2.groups.io/g/devel/message/94478 Mute This Topic: https://groups.io/mt/93975248/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
