On June 13, 2022 9:54 AM, Gao Liming wrote:
> Min:
>   I add my comments below.
> 
> >
> > @@ -83,6 +84,7 @@ EFI_MEMORY_TYPE_INFORMATION
> > gMemoryTypeInformation[EfiMaxMemoryType + 1] = {
> >    { EfiMemoryMappedIOPortSpace, 0 },
> >    { EfiPalCode,                 0 },
> >    { EfiPersistentMemory,        0 },
> > +  { EfiGcdMemoryTypeUnaccepted, 0 },
> >    { EfiMaxMemoryType,           0 }
> >  };
> 
> Here should be EfiUnacceptedMemoryType instead of
> EfiGcdMemoryTypeUnaccepted.
Sure. It will be updated in the next version.
> 
> And, based on UEFI spec 2.9, AllocatePages should return
> EFI_INVALID_PARAMETER when EfiUnacceptedMemoryType is specified.
> Please add this check.
Thanks for reminder. It will be fixed in the next version.

Thanks
Min


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90528): https://edk2.groups.io/g/devel/message/90528
Mute This Topic: https://groups.io/mt/91570199/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to