On Mon, Jun 06, 2022 at 10:59:50AM +0800, Min Xu wrote: > From: Min M Xu <min.m...@intel.com> > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. > But this defitinion has not been officially in the PI spec. Base > on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at > MdeModulePkg/Include/Pi/PrePiHob.h and update EFI_RESOURCE_MAX_MEMORY_TYPE > to 8. After EFI_RESOURCE_MEMORY_UNACCEPTED is officially published > in PI spec, we will re-visit here. > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang....@intel.com> > Cc: Erdem Aktas <erdemak...@google.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: James Bottomley <j...@linux.ibm.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Signed-off-by: Min Xu <min.m...@intel.com> > --- > MdePkg/Include/Pi/PiHob.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Pi/PiHob.h b/MdePkg/Include/Pi/PiHob.h > index e9f0ab4309d1..9af2e957fee5 100644 > --- a/MdePkg/Include/Pi/PiHob.h > +++ b/MdePkg/Include/Pi/PiHob.h > @@ -232,7 +232,16 @@ typedef UINT32 EFI_RESOURCE_TYPE; > #define EFI_RESOURCE_MEMORY_MAPPED_IO_PORT 0x00000004 > #define EFI_RESOURCE_MEMORY_RESERVED 0x00000005 > #define EFI_RESOURCE_IO_RESERVED 0x00000006 > -#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000007 > +// > +// EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. > +// But this defitinion has not been officially in the PI spec. Base > +// on the code-first we define EFI_RESOURCE_MEMORY_UNACCEPTED at > +// MdeModulePkg/Include/Pi/PrePiHob.h and update EFI_RESOURCE_MAX_MEMORY_TYPE > +// to 8. After EFI_RESOURCE_MEMORY_UNACCEPTED is officially published > +// in PI spec, we will re-visit here. > +// > +// #define EFI_RESOURCE_MEMORY_UNACCEPTED 0x00000007 > +#define EFI_RESOURCE_MAX_MEMORY_TYPE 0x00000008
Shouldn't this be handled in PrePiHob.h too? i.e. update EFI_RESOURCE_MAX_MEMORY_TYPE with #undef + #define there? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90283): https://edk2.groups.io/g/devel/message/90283 Mute This Topic: https://groups.io/mt/91570194/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
