Hi Michael,

Thank you for this patch. These changes look good to me.

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar

On 17/05/2022, 17:01, "mikub...@linux.microsoft.com" 
<mikub...@linux.microsoft.com> wrote:

    From: Michael Kubacki <michael.kuba...@microsoft.com>

    The SpellCheck plugin began reporting new typos that were previously
    missed. This change fixes those typos.

    Cc: Sami Mujawar <sami.muja...@arm.com>
    Cc: Alexei Fedorov <alexei.fedo...@arm.com>
    Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
    ---
     DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c           
  |  2 +-
     
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c |  
2 +-
     DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c    
  |  2 +-
     DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c            
  |  2 +-
     DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c                  
  |  2 +-
     DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c                      
  |  2 +-
     DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c       
  |  4 +--
     DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c         
  |  2 +-
     DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c   
  |  2 +-
     DynamicTablesPkg/DynamicTablesPkg.ci.yaml                                  
  | 31 +++++++++++++++-----
     DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h                      
  |  4 +--
     DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h            
  |  2 +-
     DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h         
  |  2 +-
     DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h   
  |  2 +-
     DynamicTablesPkg/Readme.md                                                 
  |  4 +--
     15 files changed, 41 insertions(+), 24 deletions(-)

    diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
    index 59001378c4e0..83bda4cfba67 100644
    --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
    +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
    @@ -352,7 +352,7 @@ AddPrivateResources (
           return Status;
         }

    -    // The Node indexer has the Processor hierarchy nodes at the begining
    +    // The Node indexer has the Processor hierarchy nodes at the beginning
         // followed by the cache structs. Therefore we can skip the Processor
         // hierarchy nodes in the node indexer search.
         Status = GetPpttNodeReferencedByToken (
    diff --git 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
    index 18c8b8d24525..b823b412caae 100644
    --- 
a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
    +++ 
b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
    @@ -377,7 +377,7 @@ FixupCmn600Info (
         goto error_handler;
       }

    -  // Serialise the definition block
    +  // Serialize the definition block
       Status = AmlSerializeDefinitionBlock (
                  RootNodeHandle,
                  Table
    diff --git 
a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c 
b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
    index dafbd19fde15..32c3ab534d0b 100644
    --- 
a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
    +++ 
b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
    @@ -619,7 +619,7 @@ AmlCodeGenRdDWordMemory (
       See ACPI 6.4 spec, s19.2.8 for more.

       @param [in]  IsReadWrite          ReadAndWrite parameter.
    -  @param [in]  Addres               AddressBase parameter.
    +  @param [in]  Address              AddressBase parameter.
       @param [in]  RangeLength          Range length.
       @param [in]  NameOpNode           NameOp object node defining a named 
object.
                                         If provided, append the new resource 
data
    diff --git 
a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c 
b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
    index 8c77716dab80..60694819fb4c 100644
    --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
    +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
    @@ -1284,7 +1284,7 @@ AmlAddNameSpaceReference (
       When computing the size of a tree or serializing it, the additional data 
is
       not taken into account (i.e. the MethodInvocationOp and the 
ArgumentCount).

    -  Method invocation nodes have the AML_METHOD_INVOVATION attribute.
    +  Method invocation nodes have the AML_METHOD_INVOCATION attribute.

       @param  [in]  NameSpaceRefNode          NameSpaceRef node pointing to the
                                               the definition of the invoked
    diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c 
b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
    index 8e584d49307a..6f80725bf13d 100644
    --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
    +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
    @@ -331,7 +331,7 @@ AmlParseString (
       StrSize = 0;
       // AML String is NULL terminated.
       do {
    -    // Reading the stream moves the stream forward aswell.
    +    // Reading the stream moves the stream forward as well.
         Status = AmlStreamReadByte (FStream, &Byte);
         if (EFI_ERROR (Status)) {
           ASSERT (0);
    diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c 
b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
    index 1404a2182b65..0a744f1ff3fa 100644
    --- a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
    +++ b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
    @@ -573,7 +573,7 @@ AmlIsMethodDefinitionNode (
     {
       AML_DATA_NODE  *ObjectType;

    -  // Node is checked to be an object node aswell.
    +  // Node is checked to be an object node as well.
       if (AmlNodeCompareOpCode (Node, AML_METHOD_OP, 0)) {
         return TRUE;
       } else if (AmlNodeCompareOpCode (Node, AML_EXTERNAL_OP, 0)) {
    diff --git 
a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c 
b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
    index bc713f30b2fe..1244bbda702d 100644
    --- a/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
    +++ b/DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
    @@ -294,9 +294,9 @@ GroupCmObjNodes (
       return Status;
     }

    -/** Finalise the dynamic repository.
    +/** Finalize the dynamic repository.

    -  Finalising means:
    +  Finalizing means:
        - Preventing any further objects from being added.
        - Allowing to get objects from the dynamic repository
          (not possible before a call to this function).
    diff --git 
a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c 
b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
    index 831f0d5b7365..d38a331f4822 100644
    --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
    +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
    @@ -88,7 +88,7 @@ GetGicVersion (

     /** Gic dispatcher.

    -  This disptacher populates the following structures:
    +  This dispatcher populates the following structures:
        - CM_ARM_GICC_INFO
        - CM_ARM_GICD_INFO
        - CM_ARM_GIC_MSI_FRAME_INFO
    diff --git 
a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c 
b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
    index 0557e416b44c..71e92ee1fb14 100644
    --- 
a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
    +++ 
b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
    @@ -447,7 +447,7 @@ ArmSerialPortInfoParser (

     /** SerialPort dispatcher.

    -  This disptacher populates the CM_ARM_SERIAL_PORT_INFO structure for
    +  This dispatcher populates the CM_ARM_SERIAL_PORT_INFO structure for
       the following CM_OBJ_ID:
        - EArmObjSerialConsolePortInfo
        - EArmObjSerialDebugPortInfo
    diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml 
b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
    index bfa282926e48..2d2f3405e467 100644
    --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
    +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
    @@ -92,35 +92,52 @@
             "IgnoreFiles": [],           # use gitignore syntax to ignore 
errors
                                          # in matching files
             "ExtendWords": [
    +           "aaaabbbbcccc",
    +           "AMLDBG",
                "ARMHB",                  # ARMHB000
                "ARMHC",                  # ARMHC600
                "ARMLTD",
    -           "AMLDBG",
    -           "EISAID",
    +           "bytecodes",
    +           "bytelist",
    +           "bytestream",
                "CCIDX",
                "CCSIDR",
                "countof",
    +           "deregistering",
    +           "devicetree",
                "edynamic",
    +           "EISAID",
                "EOBJECT",
    +           "etable",
    +           "finalise",
    +           "GTBLOCK",
                "invoc",
                "ITARGETSR",
    -           "GTBLOCK",
                "lgreater",
                "lless",
    +           "mainpage",
    +           "mismanipulation",
                "MPIDR",
    +           "nameseg",
    +           "namespaceid",
    +           "namespacestring",
    +           "namestr",
                "PERIPHBASE",
                "phandle",
    +           "pkglen",
    +           "prefetchable",
                "pytool",
                "Rdword",
    +           "redist",
                "Roadmap",
                "ROOTNODEBASE",
    -           "ssdtcmn",
    -           "ssdtserialporttemplate",
                "SMMUV",
    -           "ssdtpcieosctemplate",
    +           "ssdtcmn",
                "SSDTPC",
    -           "standardised",
    +           "ssdtpcieosctemplate",
    +           "ssdtserialporttemplate",
                "TABLEEX",
    +           "tagsize",
                "TNSID",
                "Vatos",
                "WBINVD"
    diff --git a/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h 
b/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
    index bb18215b08bc..c3cd6b5728ff 100644
    --- a/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
    +++ b/DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
    @@ -38,9 +38,9 @@ DynPlatRepoAddObject (
       OUT       CM_OBJECT_TOKEN                   *Token OPTIONAL
       );

    -/** Finalise the dynamic repository.
    +/** Finalize the dynamic repository.

    -  Finalising means:
    +  Finalizing means:
        - Preventing any further objects from being added.
        - Allowing to get objects from the dynamic repository
          (not possible before a call to this function).
    diff --git 
a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h 
b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h
    index ac3284d0311e..6e4837956f74 100644
    --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h
    +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h
    @@ -138,7 +138,7 @@ AmlAddNameSpaceReference (
       When computing the size of a tree or serializing it, the additional data 
is
       not taken into account (i.e. the MethodInvocationOp and the 
ArgumentCount).

    -  Method invocation nodes have the AML_METHOD_INVOVATION attribute.
    +  Method invocation nodes have the AML_METHOD_INVOCATION attribute.

       @param  [in]  NameSpaceRefNode          NameSpaceRef node pointing to the
                                               the definition of the invoked
    diff --git 
a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h 
b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
    index aa942f7d1f49..65c5968baa57 100644
    --- a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
    +++ b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
    @@ -40,7 +40,7 @@ GetGicVersion (

     /** Gic dispatcher.

    -  This disptacher populates the following structures:
    +  This dispatcher populates the following structures:
        - CM_ARM_GICC_INFO
        - CM_ARM_GICD_INFO
        - CM_ARM_GIC_MSI_FRAME_INFO
    diff --git 
a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h 
b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h
    index de08e57e6c57..cec93d389240 100644
    --- 
a/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h
    +++ 
b/DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h
    @@ -14,7 +14,7 @@

     /** SerialPort dispatcher.

    -  This disptacher populates the CM_ARM_SERIAL_PORT_INFO structure for
    +  This dispatcher populates the CM_ARM_SERIAL_PORT_INFO structure for
       the following CM_OBJ_ID:
        - EArmObjSerialConsolePortInfo
        - EArmObjSerialDebugPortInfo
    diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md
    index 5f92d4c6cb2e..f5b3f65cd9af 100644
    --- a/DynamicTablesPkg/Readme.md
    +++ b/DynamicTablesPkg/Readme.md
    @@ -11,9 +11,9 @@ UEFI modules.

     # Feature Summary

    -The dynamic tables framework is designed to generate standardised
    +The dynamic tables framework is designed to generate standardized
     firmware tables that describe the hardware information at
    -run-time. A goal of standardised firmware is to have a common
    +run-time. A goal of standardized firmware is to have a common
     firmware for a platform capable of booting both Windows and Linux
     operating systems.

    -- 
    2.28.0.windows.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89848): https://edk2.groups.io/g/devel/message/89848
Mute This Topic: https://groups.io/mt/91166954/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to