Hi Ard,
I think that's a reasonable approach.
We could also consider locking onto a specific cspell version to
decrease the likelihood of this sporadically appearing in the future.
In this case, I would prefer not to make the decision to disable spell
check entirely on behalf of various package maintainers though. I'm just
trying to keep the status quo from unblocking other changes.
Do you think that's something you or others could add as a change on top
of this series?
Thanks,
Michael
On 5/17/2022 12:13 PM, Ard Biesheuvel wrote:
Hello Michael,
Thanks for taking care of this. However, I strongly feel that
automation is increasing my workload here rather than the other way
around, for dubious benefits, so as a package maintainer, I am
inclined to disable the spell checks altogether for all the packages I
am in charge of.
On Tue, 17 May 2022 at 18:01, <mikub...@linux.microsoft.com> wrote:
From: Michael Kubacki <michael.kuba...@microsoft.com>
The SpellCheck plugin began reporting new typos that were previously
missed. This is impacting edk2 pull requests from being completed.
A change in the cspell plugin or some other upstream component may
have caused them to appear now. This patch series mitigates the
issue by fixing legitimate spelling issues and adding new ignored
words if appropriate.
Fixes in ArmPkg were deferred due to the number of reported issues
in the package. The maintainers should follow up by reviewing the
extended word list for SpellCheck in ArmPkg.ci.yaml and determining
the best resolution for each item.
That follow up task for ArmPkg was filed in the following BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=3929
Cc: Alexei Fedorov <alexei.fedo...@arm.com>
Cc: Ankit Sinha <ankit.si...@intel.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Bret Barkelew <bret.barke...@microsoft.com>
Cc: Gerd Hoffmann <kra...@redhat.com>
Cc: Guomin Jiang <guomin.ji...@intel.com>
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Leif Lindholm <quic_llind...@quicinc.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Michael Kubacki <mikub...@linux.microsoft.com>
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Cc: Sami Mujawar <sami.muja...@arm.com>
Cc: Sean Brogan <sean.bro...@microsoft.com>
Cc: Supreeth Venkatesh <supreeth.venkat...@arm.com>
Cc: Wei6 Xu <wei6...@intel.com>
Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
Michael Kubacki (8):
PrmPkg: Fix new typos reported
StandaloneMmPkg: Fix new typos reported
DynamicTablesPkg: Fix new typos reported
UnitTestFrameworkPkg: Fix new typos reported
FatPkg: Fix new typos reported
FmpDevicePkg: Fix new typos reported
ArmPkg: Ignore new typos reported
ArmVirtPkg: Add new ignored spelling errors
DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
| 2 +-
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
| 2 +-
DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
| 2 +-
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c
| 2 +-
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
| 2 +-
DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c
| 2 +-
DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c
| 4 +-
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c
| 2 +-
DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c
| 2 +-
FatPkg/EnhancedFatDxe/FileSpace.c
| 2 +-
FatPkg/EnhancedFatDxe/ReadWrite.c
| 2 +-
FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c
| 2 +-
PrmPkg/Application/PrmInfo/PrmInfo.c
| 2 +-
PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c
| 2 +-
PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c
| 2 +-
PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestImage.c
| 2 +-
PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTestProtocol.c
| 2 +-
StandaloneMmPkg/Core/Dependency.c
| 2 +-
StandaloneMmPkg/Core/Dispatcher.c
| 18 +++----
UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c
| 18 +++----
UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c
| 2 +-
UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c
| 2 +-
UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
| 2 +-
UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c
| 2 +-
UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c
| 2 +-
ArmPkg/ArmPkg.ci.yaml
| 55 +++++++++++++++++++-
ArmVirtPkg/ArmVirtPkg.ci.yaml
| 25 +++++----
DynamicTablesPkg/DynamicTablesPkg.ci.yaml
| 31 ++++++++---
DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h
| 4 +-
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h
| 2 +-
DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h
| 2 +-
DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h
| 2 +-
DynamicTablesPkg/Readme.md
| 4 +-
FatPkg/EnhancedFatDxe/Fat.h
| 2 +-
FatPkg/FatPkg.ci.yaml
| 22 ++++++--
FmpDevicePkg/FmpDevicePkg.ci.yaml
| 4 ++
PrmPkg/Include/Library/PrmModuleDiscoveryLib.h
| 2 +-
PrmPkg/PrmLoaderDxe/PrmAcpiTable.h
| 4 +-
PrmPkg/PrmPkg.ci.yaml
| 9 ++++
PrmPkg/Test/UnitTest/Library/UefiBootServicesTableLibUnitTest/UefiBootServicesTableLibUnitTest.h
| 4 +-
StandaloneMmPkg/Include/Guid/MmCoreData.h
| 2 +-
StandaloneMmPkg/StandaloneMmPkg.ci.yaml
| 9 ++++
UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h
| 2 +-
UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h
| 2 +-
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml
| 29 +++++++----
45 files changed, 209 insertions(+), 91 deletions(-)
--
2.28.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89846): https://edk2.groups.io/g/devel/message/89846
Mute This Topic: https://groups.io/mt/91166946/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
