Re-opening the elliptic curves debate after running into the recent openssl changes. The current implementation is IMHO rather messy. It adds manual changes to a auto-generated files, which will make any updates a rather hard and error-prone process.
I see two possible options how we can move forward: (1) Drop the idea to make EC configurable and just enable it unconditionally. I think long-term there is no way around this anyway as EC is a hard requirement for TLS 1.3. (2) Keep the EC config option, but update process_files.pl to automatically add the PcdEcEnabled config option handling to the files it generates. This patch set does (1). It also tweaks ovmf firmware volumes to make CI tests pass and it also excludes generated files from codestyle checks. take care, Gerd Gerd Hoffmann (5): Revert "CryptoPkg: Declare PcdEcEnabled in Library consuming OpensslLib" Revert "CryptoPkg: Make EC source file config-able" OvmfPkg: make DXEFV larger CryptoPkg/openssl: update generated files CryptoPkg/openssl: disable codestyle checks for generated files CryptoPkg/CryptoPkg.dec | 4 - OvmfPkg/OvmfPkgIa32.fdf | 6 +- OvmfPkg/OvmfPkgIa32X64.fdf | 6 +- OvmfPkg/OvmfPkgX64.fdf | 6 +- .../Library/BaseCryptLib/BaseCryptLib.inf | 3 - .../Library/BaseCryptLib/PeiCryptLib.inf | 3 - .../Library/BaseCryptLib/RuntimeCryptLib.inf | 3 - .../Library/BaseCryptLib/SmmCryptLib.inf | 3 - .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 - CryptoPkg/Library/OpensslLib/OpensslLib.inf | 99 ++++---- .../Library/OpensslLib/OpensslLibCrypto.inf | 99 ++++---- CryptoPkg/Library/TlsLib/TlsLib.inf | 3 - CryptoPkg/Library/Include/crypto/dso_conf.h | 7 +- .../Library/Include/openssl/opensslconf.h | 240 ++++++++---------- CryptoPkg/CryptoPkg.ci.yaml | 10 + 15 files changed, 234 insertions(+), 261 deletions(-) -- 2.35.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89457): https://edk2.groups.io/g/devel/message/89457 Mute This Topic: https://groups.io/mt/90832153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-