On Thu, Apr 7, 2022 at 2:46 PM Rabeda, Maciej
<maciej.rab...@linux.intel.com> wrote:
> 1. In HttpResponseWorker():
>
> if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen
> ("HTTP/1.0")) == 0) {
> DEBUG ((DEBUG_VERBOSE, "HTTP: Server version is 1.0. Setting
> Connection close.\n"));
> HttpInstance->ConnectionClose = TRUE;
> }
>
> I'd change AsciiStrLen ("HTTP/1.0") to sizeof("HTTP/1.0") - 1. No need
> to call a AsciiStrLen every time this flow is executed, it is easily a
> compile-time thing.
Yes, of course.
> 2. In HttpResponseWorker(), index -> Index, coding standard.
Sorry, I missed that one.
> I can merge this patch with changes above one I get an ACK from you.
Sounds good to me. Thank you!
-- Oliver
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88528): https://edk2.groups.io/g/devel/message/88528
Mute This Topic: https://groups.io/mt/89966934/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
