Hi Gerd,

Sorry, I can spare very little time for reviews these days...

I am alright with the patch with two cosmetic changes.

1. In HttpResponseWorker():

    if (AsciiStrnCmp (HttpHeaders, "HTTP/1.0", AsciiStrLen ("HTTP/1.0")) == 0) {       DEBUG ((DEBUG_VERBOSE, "HTTP: Server version is 1.0. Setting Connection close.\n"));
      HttpInstance->ConnectionClose = TRUE;
    }

I'd change AsciiStrLen ("HTTP/1.0") to sizeof("HTTP/1.0") - 1. No need to call a AsciiStrLen every time this flow is executed, it is easily a compile-time thing.

2. In HttpResponseWorker(), index -> Index, coding standard.

I can merge this patch with changes above one I get an ACK from you.

Thanks,
Maciej

On 7 kwi 2022 11:57, Gerd Hoffmann wrote:
On Wed, Mar 23, 2022 at 09:19:09AM +0800, gaoliming wrote:
Maciej, Jiaxin and Siyuan:
   Can you help review this fix?
Ping.  Anything blocking the merge of these bugfixes?

thanks,
   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88526): https://edk2.groups.io/g/devel/message/88526
Mute This Topic: https://groups.io/mt/89966934/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to