Hi Rebecca,
Thanks for catching this.
I think we also need to add a check in Acpiview to report this issue. However,
that would be another patch series.
Regards,
Sami Mujawar
From: Rebecca Cran <quic_rc...@quicinc.com>
Date: Monday, 31 January 2022 at 15:17
To: devel@edk2.groups.io <devel@edk2.groups.io>, Pierre Gondois
<pierre.gond...@arm.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>, Sami Mujawar
<sami.muja...@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table
On 1/28/22 08:41, PierreGondois wrote:
> + Differentiated System Description Table Fields (DSDT)
> +
> + Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.<BR>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) {
The Revision field should probably be 2, not 1. ACPI 6.4 says:
2. This field also sets the global integer width for the AML
interpreter. Values less than two will cause the inter-
preter to use 32-bit integers and math. Values of two
and greater will cause the interpreter to use full 64-bit
integers and math.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86256): https://edk2.groups.io/g/devel/message/86256
Mute This Topic: https://groups.io/mt/88746974/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
