On 11/11/21 7:27 PM, Ni, Ray wrote:
> 2 minor comments.
>
>> + switch (Attr) {
>> + case CCAttrAmdSev:
>> + return CurrentAttr >= CCAttrAmdSev;
>> + case CCAttrAmdSevEs:
>> + return CurrentAttr >= CCAttrAmdSevEs;
>> + case CCAttrAmdSevSnp:
>> + return CurrentAttr == CCAttrAmdSevSnp;
> 1. Can you put comments to explain that the relationship between the three
> features?
> That can explain why ">=" is used here.
> You may use ">=" for SEV-SNP as well, in case AMD invents a more advanced
> SEV.:)
Sure, I can add a comment.
>
>> +
>> + return (CurrentAttr == Attr);
> 2. I guess a "BOOLEAN" type cast is needed.
>
I can cast it but CI didn't complain about it.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83691): https://edk2.groups.io/g/devel/message/83691
Mute This Topic: https://groups.io/mt/86969148/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
