1 comment: Can you please group the SevEsIsEnabled/SevSnpIsEnabled to a "2 boolean" struct or just one UINT8 field "SevEsEnable"?
Through this way, MpLib.c can know less knowledge of SEV-ES. (I appreciate your effort to group the SEV-ES logic to separate files😊) > > BOOLEAN SevEsIsEnabled; > + BOOLEAN SevSnpIsEnabled; > UINTN SevEsAPBuffer; > UINTN SevEsAPResetStackStart; > > ExchangeInfo->SevEsIsEnabled = CpuMpData->SevEsIsEnabled; > + ExchangeInfo->SevSnpIsEnabled = CpuMpData->SevSnpIsEnabled; > ExchangeInfo->GhcbBase = (UINTN) CpuMpData->GhcbBase; > > InitializeSpinLock(&CpuMpData->MpLock); > CpuMpData->SevEsIsEnabled = ConfidentialComputingGuestHas (CCAttrAmdSevEs); > + CpuMpData->SevSnpIsEnabled = ConfidentialComputingGuestHas > (CCAttrAmdSevSnp); > CpuMpData->SevEsAPBuffer = (UINTN) -1; > .Enable5LevelPaging: CTYPE_BOOLEAN 1 > .SevEsIsEnabled: CTYPE_BOOLEAN 1 > + .SevSnpIsEnabled CTYPE_BOOLEAN 1 > .GhcbBase: CTYPE_UINTN 1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83671): https://edk2.groups.io/g/devel/message/83671 Mute This Topic: https://groups.io/mt/86969147/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
