Sorry for the confusing. My word is not accurate. When I say "internal" in this context, I really mean: it is produced and consumed by OVMF. The API will not be called by *third party*, such as OS loader, or Option ROM.
If so, it is OK to add ASSERT. If you look at the BaseLib, many functions add ASSERT. It can help to check the usage of API is correctly. Thank you Yao Jiewen > -----Original Message----- > From: Xu, Min M <min.m...@intel.com> > Sent: Friday, November 12, 2021 1:30 PM > To: Yao, Jiewen <jiewen....@intel.com>; Erdem Aktas > <erdemak...@google.com> > Cc: devel@edk2.groups.io; Kinney, Michael D <michael.d.kin...@intel.com>; > Liming Gao <gaolim...@byosoft.com.cn>; Liu, Zhiguang > <zhiguang....@intel.com>; Brijesh Singh <brijesh.si...@amd.com>; James > Bottomley <j...@linux.ibm.com>; Tom Lendacky > <thomas.lenda...@amd.com>; Gerd Hoffmann <kra...@redhat.com> > Subject: RE: [PATCH V3 02/29] MdePkg: Add TdxLib to wrap Tdx operations > > On November 12, 2021 10:42 AM, Yao Jiewen wrote: > > BTW: Is this internal API? > > I feel we should add ASSERT() for invalid page size as well, to catch issue > > earlier. > TdAcceptPages () is not an internal API. It is exposed in TdxLib. > Sure, I will add more check to the input parameter in the code. > > Thanks > Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83683): https://edk2.groups.io/g/devel/message/83683 Mute This Topic: https://groups.io/mt/86739959/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
