On November 5, 2021 2:46 PM, Gerd Hoffmann wrote: > > > Can't you create something in MdePkg/Library/Baselib and then use it > > > everywhere it's needed? > > > > > Do you mean put the basic Tdx functions in MdePkg/Library/BaseLib? If that > > is > the case, then I would add below basic Tdx functions in BaseLib: > > - TdIsEnabled () > > - TdCall () > > - TdVmCall () > > That is the cpuid-based check and the asm code for td calls, correct? > > > Gerd, what's your thought? > > Looks fine to me. > Hi, Liming & Michael You're the MdePkg maintainers. What's your thoughts about adding these Tdx functions in MdePkg/Library/BaseLib? - TdIsEnabled () <-- cpuid-based check if it is a TD guest - TdCall () <-- TD call - TdVmCall () <-- TD vmcall https://github.com/mxu9/edk2/blob/tdvf_wave2.v3/MdePkg/Library/TdxLib/X64/Tdcall.nasm https://github.com/mxu9/edk2/blob/tdvf_wave2.v3/MdePkg/Library/TdxLib/X64/Tdvmcall.nasm
Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83478): https://edk2.groups.io/g/devel/message/83478 Mute This Topic: https://groups.io/mt/86739862/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-