On October 29, 2021 7:37 PM, Gerd Hoffmann wrote:
> > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
> > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
> > @@ -670,10 +670,9 @@
> >    }
> >
> >    MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> > -  OvmfPkg/8259InterruptControllerDxe/8259.inf
> >    UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> >    UefiCpuPkg/CpuDxe/CpuDxe.inf
> > -  OvmfPkg/8254TimerDxe/8254Timer.inf
> > +  OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf
> >
> OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.i
> nf
> >    OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
> >    MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {
> 
> Also needs "gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000"
> 
> (same for the other OvmfPkg files).
Ah, thanks for reminder. The default value is 200000000. It will be fixed in 
the next version.

> 
> > --- a/OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.c
> > +++ b/OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.c
> > @@ -173,7 +173,7 @@ TimerDriverSetTimerPeriod (
> >      //
> >      DisableApicTimerInterrupt();
> >    } else {
> > -    TimerFrequency = PcdGet32(PcdFSBClock) / DivideValue;
> > +    TimerFrequency = PcdGet32(PcdFSBClock) / (UINT32)DivideValue;
> 
> Why is this cast needed?
> 
That is because of below error when build OvmfPkgX64.dsc
OvmfPkg\LocalApicTimerDxe\LocalApicTimerDxe.c(176): error C2220: warning 
treated as error - no 'object' file generated
OvmfPkg\LocalApicTimerDxe\LocalApicTimerDxe.c(176): warning C4244: '=': 
conversion from 'UINTN' to 'UINT32', possible loss of data

Thanks.
Min


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82952): https://edk2.groups.io/g/devel/message/82952
Mute This Topic: https://groups.io/mt/86671464/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to