Hi Leif,

There are two comments that I would like to clarify with you.

On 23/09/2021 20:49, Leif Lindholm wrote:
+VOID
+Ac01PcieMmioWr (
+  UINT64 Addr,
+  UINT32 Val
+  )
+{
+  Ac01PcieCsrOut32Serdes ((VOID *)Addr, (UINT32)Val);
+}
+
+VOID
+Ac01PciePuts (
Wait, what. We have *two* sets of output overlays in this patch?

This function is consumed by PCIe PHY library (PHYLib). We are making this wrapper function to conform with the function prototype defined by PHYLib.

We will reduce DEBUG_PCIE_PHY by using directly the DEBUG (). Does it look good to you?


+  CONST CHAR8 *Msg
+  )
+{
+  DEBUG_PCIE_PHY ("%a\n", __FUNCTION__);
Err, no, just a further level of abstraction, seemingly throwing away
the subsystem aspect when actually called here?

+}
+
+VOID
+Ac01PciePutInt (
+  UINT32 val
+  )
+{
+  DEBUG_PCIE_PHY ("%a\n", __FUNCTION__);
+}
+
+VOID
+Ac01PciePutHex (
+  UINT64 val
+  )
+{
+  DEBUG_PCIE_PHY ("%a\n", __FUNCTION__);
+}
+
+INT32
+Ac01PcieDebugPrint (
+  CONST CHAR8 *fmt,
+  ...
+  )
+{
+  DEBUG_PCIE_PHY ("%a\n", __FUNCTION__);
+  return 0;
+}
+
+VOID
+Ac01PcieDelay (
+  UINT32 Val
+  )
+{
+  MicroSecondDelay (Val);
No, use MicroSecondDelay directly.

Seems above. This wrapper function is to conform with the function prototype consumed by PHYLib. It's hard to change it.

Thanks,

Nhi




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81444): https://edk2.groups.io/g/devel/message/81444
Mute This Topic: https://groups.io/mt/85631150/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to