Hi Michael, Here is a summary of my feedback:
1. Patch 2/5: DxeCheckTcgTrustedBoot.c: line 44 - I think we should also have a ZeroMem ((VOID *) &ProtocolCapability, sizeof (ProtocolCapability)) before setting the size. 2. Patch 3/5: SmmTestPointCheckLib.c: line 112 - I think we should have a #define that describes whatever "6" means in this context. Everything else looks good! Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > Kubacki > Sent: Thursday, August 5, 2021 7:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com> > Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg: > TestPointCheckLib bug fixes and improvements > > From: Michael Kubacki <mailto:michael.kuba...@microsoft.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3531 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3518 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3521 > > This patch series groups together several bug fixes and improvements to > TestPointCheckLib. The first patch is required for the others since it fixes a > MinPlatformPkg build issue that occurs with the current edk2/master branch. > > Cc: Chasel Chiu <mailto:chasel.c...@intel.com> > Cc: Nate DeSimone <mailto:nathaniel.l.desim...@intel.com> > Cc: Liming Gao <mailto:gaolim...@byosoft.com.cn> > Cc: Eric Dong <mailto:eric.d...@intel.com> > Signed-off-by: Michael Kubacki <mailto:michael.kuba...@microsoft.com> > > Michael Kubacki (5): > MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue > MinPlatformPkg/TestPointCheckLib: Set required size field in protocol > MinPlatformPkg/TestPointCheckLib: Fix incorrect array index > MinPlatformPkg/TestPointCheckLib: Improve adjacent region checking > MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional > > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA > cpi.c | 32 +++++------ > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > miHandlerInstrument.c | 4 +- > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS > mmInfo.c | 56 ++++++++++---------- > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc > gTrustedBoot.c | 1 + > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.c | 15 +++++- > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo > intCheckLib.c | 4 +- > Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.c > | 10 ++-- > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi > ntCheckLib.inf | 1 + > 8 files changed, 70 insertions(+), 53 deletions(-) > > -- > 2.28.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#78710): https://edk2.groups.io/g/devel/message/78710 > Mute This Topic: https://groups.io/mt/84686301/1767664 > Group Owner: mailto:devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [nathaniel.l.desim...@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78758): https://edk2.groups.io/g/devel/message/78758 Mute This Topic: https://groups.io/mt/84686301/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
