Hi Michael, Comments are inline.
Thanks, Nate > -----Original Message----- > From: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com> > Sent: Thursday, August 5, 2021 7:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com> > Subject: [edk2-platforms][PATCH v1 3/5] > MinPlatformPkg/TestPointCheckLib: Fix incorrect array index > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520 > > TestPointSmmEndOfDxeSmrrFunctional() uses the incorrect byte index to > skip the test. It should use byte 6 instead of byte 5. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Eric Dong <eric.d...@intel.com> > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > --- > > Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo > intCheckLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest > PointCheckLib.c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest > PointCheckLib.c > index 4b4f874c7bbc..3e8b2621cccd 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTest > PointCheckLib.c > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTe > +++ stPointCheckLib.c > @@ -109,7 +109,7 @@ TestPointSmmEndOfDxeSmrrFunctional ( > EFI_STATUS Status; > BOOLEAN Result; > > - if ((mFeatureImplemented[5] & > TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUNCTIONAL) == 0) { > + if ((mFeatureImplemented[6] & > + TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUNCTIONAL) == 0) { I think we should have a #define that describes whatever "6" means in this context. > return EFI_SUCCESS; > } > > @@ -125,7 +125,7 @@ TestPointSmmEndOfDxeSmrrFunctional ( > TestPointLibSetFeaturesVerified ( > PLATFORM_TEST_POINT_ROLE_PLATFORM_IBV, > NULL, > - 5, > + 6, > TEST_POINT_BYTE6_SMM_END_OF_DXE_SMRR_FUNCTIONAL > ); > } > -- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78759): https://edk2.groups.io/g/devel/message/78759 Mute This Topic: https://groups.io/mt/84686307/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
