On 24/06/2021 16:46, Laszlo Ersek wrote:
> On 06/17/21 14:16, Dov Murik wrote:
>> This reverts commit efc52d67e1573ce174d301b52fa1577d552c8441.
>>
>> Manually fixed conflicts in:
>> OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c
>>
>> Note that besides re-exposing the kernel command line as a file in the
>> synthetic filesystem, we also revert back to AllocatePool instead of
>> AllocatePages.
>>
>> Cc: Laszlo Ersek <ler...@redhat.com>
>> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
>> Cc: Jordan Justen <jordan.l.jus...@intel.com>
>> Cc: James Bottomley <j...@linux.ibm.com>
>> Cc: Tobin Feldman-Fitzthum <to...@linux.ibm.com>
>> Signed-off-by: Dov Murik <dovmu...@linux.ibm.com>
>> ---
>> OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c | 11 ++++++++---
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> (1) The bugzilla ticket should be referenced in the commit message,
> above your signoff:
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
>
Will do. Maybe worth adding a mention of this requirement in your
contributor guide [1].
[1]
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05
> With that update:
>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Thanks!
-Dov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77139): https://edk2.groups.io/g/devel/message/77139
Mute This Topic: https://groups.io/mt/83602580/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
