Mike, The patch 3/3 is good to me. After sperate it into 2 patches, Reviewed-by: Bob Feng <bob.c.f...@intel.com>
For the patch 2/3 CryptoPkg/Library/Include, the Copyright Year is missing to change. Thanks, Bob -----Original Message----- From: Kinney, Michael D <michael.d.kin...@intel.com> Sent: Tuesday, April 13, 2021 10:39 AM To: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Lu, XiaoyuX <xiaoyux...@intel.com>; Jiang, Guomin <guomin.ji...@intel.com>; Liu, Zhiguang <zhiguang....@intel.com>; Feng, Bob C <bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com>; 'Andrew Fish' <af...@apple.com>; 'Abner Chang' <abner.ch...@hpe.com> Subject: RE: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions > -----Original Message----- > From: gaoliming <gaolim...@byosoft.com.cn> > Sent: Monday, April 12, 2021 6:28 PM > To: devel@edk2.groups.io; Kinney, Michael D > <michael.d.kin...@intel.com> > Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; Lu, XiaoyuX <xiaoyux...@intel.com>; Jiang, > Guomin <guomin.ji...@intel.com>; Liu, Zhiguang > <zhiguang....@intel.com>; Feng, Bob C <bob.c.f...@intel.com>; Chen, > Christine <yuwei.c...@intel.com>; 'Andrew Fish' <af...@apple.com>; > 'Abner Chang' <abner.ch...@hpe.com> > Subject: 回复: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture > list assumptions > > Mike: > Is this update for new ARCH support? With this patch set, new ARCH > support doesn't need to modify BaseTools. Right? Correct > > For this patch set 3/3 BaseTools/Source, I may suggest to split it > to two patches, one is for C tools, another is for Python tools. I agree. I will send V2. > > For other patch, they are good to me. Reviewed-by: Liming Gao > <gaolim...@byosoft.com.cn> > > Thanks > Liming > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D Kinney > > 发送时间: 2021年4月8日 14:33 > > 收件人: devel@edk2.groups.io > > 抄送: Jiewen Yao <jiewen....@intel.com>; Jian J Wang > > <jian.j.w...@intel.com>; Xiaoyu Lu <xiaoyux...@intel.com>; Guomin > > Jiang <guomin.ji...@intel.com>; Liming Gao > > <gaolim...@byosoft.com.cn>; Zhiguang Liu <zhiguang....@intel.com>; > > Bob Feng <bob.c.f...@intel.com>; Yuwei Chen <yuwei.c...@intel.com>; > > Andrew Fish <af...@apple.com>; Abner Chang <abner.ch...@hpe.com> > > 主题: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list > > assumptions > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3308 > > > > The EDK II Build Specifications do not restrict the set of CPU > > architectures that can be supported. Remove places in the EDK II > > that assume a fixed set of CPU architectures. > > > > Remove build breaks in the following tools and DEFINES when a check > against > > a fixed set of CPU architectures is made. > > > > * Build > > * GenFds > > * TargetTool > > * GenFw > > * SIXTY_FOUR_BIT and THIRTY_TWO_BIT > > * EFI_IMAGE_MACHINE_TYPE_SUPPORTED > > * EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED > > * EFI_REMOVABLE_MEDIA_FILE_NAME > > > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Xiaoyu Lu <xiaoyux...@intel.com>Cc > > Cc: Guomin Jiang <guomin.ji...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Cc: Bob Feng <bob.c.f...@intel.com> > > Cc: Yuwei Chen <yuwei.c...@intel.com> > > Cc: Andrew Fish <af...@apple.com> > > Cc: Abner Chang <abner.ch...@hpe.com> > > Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> > > > > Michael D Kinney (3): > > MdePkg/Include: Allow CPU specific defines to be predefined > > CryptoPkg/Library/Include: Allow CPU specific defines to be predefined > > BaseTools/Source: Remove CPU architecture assumptions > > > > BaseTools/Source/C/GenFw/Elf32Convert.c | 5 ++--- > > BaseTools/Source/C/GenFw/Elf64Convert.c | 5 ++--- > > BaseTools/Source/Python/GenFds/FdfParser.py | 4 +--- > > BaseTools/Source/Python/TargetTool/TargetTool.py | 4 ++-- > > BaseTools/Source/Python/build/buildoptions.py | 4 ++-- > > CryptoPkg/Library/Include/CrtLibSupport.h | 2 ++ > > MdePkg/Include/Uefi/UefiBaseType.h | 4 +++- > > MdePkg/Include/Uefi/UefiSpec.h | 4 +++- > > 8 files changed, 17 insertions(+), 15 deletions(-) > > > > -- > > 2.31.1.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74030): https://edk2.groups.io/g/devel/message/74030 Mute This Topic: https://groups.io/mt/82056247/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
