Hi Liming,
It didn't feel quite right to keep your Tested-by: and Reviewed-by: for
the change in v2 that I'm about to send. So please re-test / re-review.
Thanks,
Tom
On 8/19/20 2:08 AM, Gao, Liming wrote:
Tested-by: Liming Gao <[email protected]>
Reviewed-by: Liming Gao <[email protected]>
-----Original Message-----
From: Tom Lendacky <[email protected]>
Sent: 2020年8月18日 21:10
To: [email protected]
Cc: Gao, Liming <[email protected]>; Dong, Eric <[email protected]>; Ni, Ray
<[email protected]>; Laszlo Ersek <[email protected]>; Kumar, Rahul1 <[email protected]>
Subject: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement
variable
From: Tom Lendacky <[email protected]>
REF:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2901&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cb01af87f70694b578aef08d8440ea50c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637334176971927286&sdata=YSk7vULEekTRnjrd8XamlT1whKE3YkMk4lmh%2BfLf284%3D&reserved=0
The DoDecrement variable in ApWakeupFunction () wasn't always being
initialized. Update the code to always fully initialize it.
Cc: Eric Dong <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Rahul Kumar <[email protected]>
Signed-off-by: Tom Lendacky <[email protected]>
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index 90416c81b616..e24bdc64f930 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -885,9 +885,7 @@ ApWakeupFunction (
UINT64 Status;
BOOLEAN DoDecrement;
- if (CpuMpData->InitFlag == ApInitConfig) {
- DoDecrement = TRUE;
- }
+ DoDecrement = (CpuMpData->InitFlag == ApInitConfig) ? TRUE :
+ FALSE;
while (TRUE) {
Msr.GhcbPhysicalAddress = AsmReadMsr64 (MSR_SEV_ES_GHCB);
--
2.28.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64506): https://edk2.groups.io/g/devel/message/64506
Mute This Topic: https://groups.io/mt/76264245/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
