Tested-by: Liming Gao <[email protected]> Reviewed-by: Liming Gao <[email protected]>
-----Original Message----- From: Tom Lendacky <[email protected]> Sent: 2020年8月18日 21:10 To: [email protected] Cc: Gao, Liming <[email protected]>; Dong, Eric <[email protected]>; Ni, Ray <[email protected]>; Laszlo Ersek <[email protected]>; Kumar, Rahul1 <[email protected]> Subject: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable From: Tom Lendacky <[email protected]> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2901 The DoDecrement variable in ApWakeupFunction () wasn't always being initialized. Update the code to always fully initialize it. Cc: Eric Dong <[email protected]> Cc: Ray Ni <[email protected]> Cc: Laszlo Ersek <[email protected]> Cc: Rahul Kumar <[email protected]> Signed-off-by: Tom Lendacky <[email protected]> --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c index 90416c81b616..e24bdc64f930 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -885,9 +885,7 @@ ApWakeupFunction ( UINT64 Status; BOOLEAN DoDecrement; - if (CpuMpData->InitFlag == ApInitConfig) { - DoDecrement = TRUE; - } + DoDecrement = (CpuMpData->InitFlag == ApInitConfig) ? TRUE : + FALSE; while (TRUE) { Msr.GhcbPhysicalAddress = AsmReadMsr64 (MSR_SEV_ES_GHCB); -- 2.28.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64418): https://edk2.groups.io/g/devel/message/64418 Mute This Topic: https://groups.io/mt/76264245/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
