Hi Laszlo, Thank you for supporting this. I can add required support. But shouldn't we wait until the patch is reviewed and approved first? I don't know the proper procedure. Please advise.
Thank you, Vladimir > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo > Ersek > Sent: Wednesday, July 15, 2020 5:59 AM > To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com>; Zhichao > Gao <zhichao....@intel.com>; Maciej Rabeda > <maciej.rab...@linux.intel.com>; Jiaxin Wu <jiaxin...@intel.com>; Siyuan > Fu <siyuan...@intel.com>; Ray Ni <ray...@intel.com>; Liming Gao > <liming....@intel.com>; Nd <n...@arm.com> > Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 07/15/20 14:55, Laszlo Ersek wrote: > > On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > >> Introduce an http client utilizing EDK2 HTTP protocol, to allow fast > >> image downloading from http/https servers. > >> HTTP download speed is usually faster than tftp. > >> The client is based on the same approach as tftp dynamic command, and > >> uses the same UEFI Shell command line parameters. This makes it easy > >> integrating http into existing UEFI Shell scripts. > >> Note that to enable HTTP download, feature Pcd > >> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set > to > >> TRUE. > >> > >> Signed-off-by: Vladimir Olovyannikov > >> <vladimir.olovyanni...@broadcom.com> > >> Tested-By: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> > >> Cc: Zhichao Gao <zhichao....@intel.com> > >> Cc: Maciej Rabeda <maciej.rab...@linux.intel.com> > >> Cc: Jiaxin Wu <jiaxin...@intel.com> > >> Cc: Siyuan Fu <siyuan...@intel.com> > >> Cc: Ray Ni <ray...@intel.com> > >> Cc: Liming Gao <liming....@intel.com> > >> Cc: Nd <n...@arm.com> > >> --- > >> .../DynamicCommand/HttpDynamicCommand/Http.c | 1700 > +++++++++++++++++ > >> .../DynamicCommand/HttpDynamicCommand/Http.h | 84 + > >> .../HttpDynamicCommand/Http.uni | 113 ++ > >> .../HttpDynamicCommand/HttpApp.c | 53 + > >> .../HttpDynamicCommand/HttpApp.inf | 58 + > >> .../HttpDynamicCommand/HttpDynamicCommand.c | 134 ++ > >> .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + > >> ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + > >> ShellPkg/ShellPkg.dec | 1 + > >> ShellPkg/ShellPkg.dsc | 5 + > >> 10 files changed, 2216 insertions(+) create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > >> create mode 100644 > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h > >> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni > >> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c > >> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf > >> create mode 100644 > >> > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .c > >> create mode 100644 > >> > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf > > > > This feature sounds very attractive for virtualization too. > > > > I suggest filing a BZ for collecting the various versions of the patch > > (or patch series) in a common spot. (Based on the size of the patch, I > > assume there could be multiple versions.) > > Sorry, I didn't look carefully enough at the subject -- I see we're > already at v3. > In that case, the BZ should please reference all three versions of the > patch > (thus far): > > * version 1: > [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > https://edk2.groups.io/g/devel/message/53483 > http://mid.mail-archive.com/20200125005718.8931-1- > vladimir.olovyanni...@broadcom.com > > * version 2: > [edk2-devel] [PATCH v2 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > https://edk2.groups.io/g/devel/message/59160 > http://mid.mail-archive.com/20200511180310.30964-1- > vladimir.olovyanni...@broadcom.com > > * version 3 (this version): > [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > https://edk2.groups.io/g/devel/message/62452 > http://mid.mail-archive.com/20200713183137.9825-1- > vladimir.olovyanni...@broadcom.com > > Thanks! > Laszlo > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62636): https://edk2.groups.io/g/devel/message/62636 Mute This Topic: https://groups.io/mt/75483573/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
