On 07/01/20 06:04, Gary Lin wrote:
> Create the driver with only a dummy LsiScsiEntryPoint() for the further
> implementation of the driver for LSI 53C895A SCSI controller.
>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheu...@arm.com>
> Signed-off-by: Gary Lin <g...@suse.com>
> ---
> OvmfPkg/LsiScsiDxe/LsiScsi.c | 25 +++++++++++++++++++++++++
> OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 26 ++++++++++++++++++++++++++
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++++
> OvmfPkg/OvmfPkgIa32.fdf | 3 +++
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++
> OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++
> OvmfPkg/OvmfPkgX64.dsc | 4 ++++
> OvmfPkg/OvmfPkgX64.fdf | 3 +++
> 8 files changed, 72 insertions(+)
> create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsi.c
> create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
>
> diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c
> new file mode 100644
> index 000000000000..9c90941688ed
> --- /dev/null
> +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.c
> @@ -0,0 +1,25 @@
> +/** @file
> +
> + This driver produces Extended SCSI Pass Thru Protocol instances for
> + LSI 53C895A SCSI devices.
> +
> + Copyright (C) 2020, SUSE LLC.
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Uefi/UefiSpec.h>
> +
> +//
> +// Entry point of this driver
> +//
> +EFI_STATUS
> +EFIAPI
> +LsiScsiEntryPoint (
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE *SystemTable
> + )
> +{
> + return EFI_UNSUPPORTED;
> +}
> diff --git a/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> new file mode 100644
> index 000000000000..55b483c2fa20
> --- /dev/null
> +++ b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> @@ -0,0 +1,26 @@
> +## @file
> +# This driver produces Extended SCSI Pass Thru Protocol instances for
> +# LSI 53C895A SCSI devices.
> +#
> +# Copyright (C) 2020, SUSE LLC.
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> + INF_VERSION = 1.29
> + BASE_NAME = LsiScsiDxe
> + FILE_GUID = EB4EB21f-5A3D-40BE-8BD2-F1B0E38E5744
(1) The GUID should not be written in mixed case. Please pick upper case
or lower case for the whole GUID string.
(I wonder how you created the current (mixed-case) GUID string...
uuidgen outputs lower case, and I wonder how one can translate
everything except the *first* "f" from that to upper case. I hope you
didn't manually update a previously generated GUID!)
with the spelling fixed, or the GUID regenerated:
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Thanks
Laszlo
> + MODULE_TYPE = UEFI_DRIVER
> + VERSION_STRING = 1.0
> + ENTRY_POINT = LsiScsiEntryPoint
> +
> +[Sources]
> + LsiScsi.c
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> +
> +[LibraryClasses]
> + UefiDriverEntryPoint
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index b4ee7376791b..9178ffeb71cb 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -50,6 +50,7 @@ [Defines]
> #
> DEFINE PVSCSI_ENABLE = TRUE
> DEFINE MPT_SCSI_ENABLE = TRUE
> + DEFINE LSI_SCSI_ENABLE = FALSE
>
> #
> # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly
> to
> @@ -771,6 +772,9 @@ [Components]
> !endif
> !if $(MPT_SCSI_ENABLE) == TRUE
> OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> +!endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> !endif
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>
> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
> index e2b759aa8d05..2b9a6b58015f 100644
> --- a/OvmfPkg/OvmfPkgIa32.fdf
> +++ b/OvmfPkg/OvmfPkgIa32.fdf
> @@ -236,6 +236,9 @@ [FV.DXEFV]
> !if $(MPT_SCSI_ENABLE) == TRUE
> INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> !endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> +!endif
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> INF
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index ed68b080f2a2..a665f78f0dc7 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -49,6 +49,7 @@ [Defines]
> #
> DEFINE PVSCSI_ENABLE = TRUE
> DEFINE MPT_SCSI_ENABLE = TRUE
> + DEFINE LSI_SCSI_ENABLE = FALSE
>
> #
> # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly
> to
> @@ -785,6 +786,9 @@ [Components.X64]
> !endif
> !if $(MPT_SCSI_ENABLE) == TRUE
> OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> +!endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> !endif
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>
> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
> index bfca1eff9e83..83ff6aef2e8c 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.fdf
> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
> @@ -237,6 +237,9 @@ [FV.DXEFV]
> !if $(MPT_SCSI_ENABLE) == TRUE
> INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> !endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> +!endif
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> INF
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index cb7e8068a3d8..17f345acf4ee 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -49,6 +49,7 @@ [Defines]
> #
> DEFINE PVSCSI_ENABLE = TRUE
> DEFINE MPT_SCSI_ENABLE = TRUE
> + DEFINE LSI_SCSI_ENABLE = FALSE
>
> #
> # Flash size selection. Setting FD_SIZE_IN_KB on the command line directly
> to
> @@ -781,6 +782,9 @@ [Components]
> !endif
> !if $(MPT_SCSI_ENABLE) == TRUE
> OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> +!endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> + OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> !endif
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
>
> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
> index bfca1eff9e83..83ff6aef2e8c 100644
> --- a/OvmfPkg/OvmfPkgX64.fdf
> +++ b/OvmfPkg/OvmfPkgX64.fdf
> @@ -237,6 +237,9 @@ [FV.DXEFV]
> !if $(MPT_SCSI_ENABLE) == TRUE
> INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf
> !endif
> +!if $(LSI_SCSI_ENABLE) == TRUE
> +INF OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
> +!endif
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> INF
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#62119): https://edk2.groups.io/g/devel/message/62119
Mute This Topic: https://groups.io/mt/75228755/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
