Hi Garrett, On 06/19/20 03:00, Dong, Eric wrote: > Hi Garrett, > > I create a pull request to verify your changes and it reports some > errors for your changes. https://github.com/tianocore/edk2/pull/710 > > please help to resolve these errors before sending your new version > changes, also you can create your PR to verify your new changes.
It seems like the standalone "PcAtChipsetPkg.dsc" build failed. The reason seems to be that PcAtChipsetPkg.dsc contains a lib class resolution like LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf but does not contain a UefiCpuLib class resolution. Speaking more generally, the following DSC files reference at least one of "BaseXApicLib.inf" and "BaseXApicX2ApicLib.inf": - edk2: IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc OvmfPkg/OvmfPkgIa32.dsc OvmfPkg/OvmfPkgIa32X64.dsc OvmfPkg/OvmfPkgX64.dsc OvmfPkg/OvmfXen.dsc PcAtChipsetPkg/PcAtChipsetPkg.dsc SourceLevelDebugPkg/SourceLevelDebugPkg.dsc UefiCpuPkg/UefiCpuPkg.dsc UefiPayloadPkg/UefiPayloadPkgIa32.dsc UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc - edk2-platforms: Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc Platform/Intel/QuarkPlatformPkg/Quark.dsc Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc Among these files, the following ones do *not* already have the UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf lib class resolution: - edk2: PcAtChipsetPkg/PcAtChipsetPkg.dsc [found by CI] SourceLevelDebugPkg/SourceLevelDebugPkg.dsc - edk2-platforms: [none] Therefore, this patch set is sound, it is just incomplete. We need two patches *prepended*: one patch that adds the UefiCpuLib resolution to "PcAtChipsetPkg/PcAtChipsetPkg.dsc", and another that adds the same resolution to "SourceLevelDebugPkg/SourceLevelDebugPkg.dsc". Then the current (v2) patches can be included verbatim as patch v3 #3, and patch v3 #4. Garrett: you can also invoke a personal CI run -- just submit a github.com pull request with your v3 patches, before posting them to the list. You will not be able to set the "push" label on your PR, so the CI system will auto-close the PR (without merging it). But, it will tell you the build result (pass or failure). Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61525): https://edk2.groups.io/g/devel/message/61525 Mute This Topic: https://groups.io/mt/74960774/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
