Hi Garrett, I create a pull request to verify your changes and it reports some errors for your changes. https://github.com/tianocore/edk2/pull/710
please help to resolve these errors before sending your new version changes, also you can create your PR to verify your new changes. Thanks, Eric > -----Original Message----- > From: Garrett Kirkendall <garrett.kirkend...@amd.com> > Sent: Thursday, June 18, 2020 11:23 PM > To: devel@edk2.groups.io > Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Laszlo > Ersek <ler...@redhat.com> > Subject: [PATCH v2 0/2] AMD procesor MSR_IA32_MISC_ENABLE > > AMD processor does not support MSR_IA32_MISC_ENABLE register. > Accessing this register on AMD causes an unhandled exception in > SmmEntry.nasm and a subsequent failure to boot since this is too early in > SMM path for the exception handler to be loaded. > > First, to distinguish between AMD and other processors, refactor > StandardSignatureIsAuthenticAMD into BaseUefiCpuLib. So there is only one > copy in the source. All changed modules already include UefiCpuLib either > directly or indirectly so could not easly split first patch. > > Second, Skip manipulation of MSR_IA32_MISC_ENABLE register if running on > an AMD processor. > > Tested on AMD X64 hardware. > OvmfIa32 and OvmfIa32X64 on Intel hardware. > > Garrett Kirkendall (2): > UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib > UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE > manipulation on > AMD > > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf | 7 ++++ > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf | 2 ++ > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf | 2 ++ > UefiCpuPkg/Include/Library/UefiCpuLib.h | 14 ++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 3 ++ > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c | 38 > ++++++++++++++++++++ > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 25 > ++----------- > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 25 ++------ > ----- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 > ------------ > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 9 ++++- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 19 > ++++++++-- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 20 > +++++++++-- > 12 files changed, 113 insertions(+), 74 deletions(-) create mode 100644 > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c > > Changes at: > https://github.com/gkirkendall- > amd/edk2/tree/smmentry_nasm_skip_msr_xd_bit_on_amd_v2 > > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Garrett Kirkendall <garrett.kirkend...@amd.com> > > -- > 2.27.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61507): https://edk2.groups.io/g/devel/message/61507 Mute This Topic: https://groups.io/mt/74960774/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
