On Fri, Apr 24, 2020 at 08:05:53PM +0200, Laszlo Ersek wrote: > On 04/23/20 11:53, Anthony PERARD wrote: > > [LibraryClasses.common.SEC] > > QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf > > +!ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE) > > + > > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf > > +!else > > > > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPort.inf > > +!endif > > (1) This part can be simplified with an !ifndef, instead, I think. (When > DEBUG_ON_HYPERVISOR_CONSOLE is defined, then the default resolution can > take effect for SEC too.)
Sounds good. > If you wish I can change this for you as well. Alternatively, if you'd > rather repost, that's OK too. (And maybe Phil intends to review more of > the patches in this series; I'm not sure.) Feel free to edit on commit. > With (1) updated: > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks, -- Anthony PERARD -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58176): https://edk2.groups.io/g/devel/message/58176 Mute This Topic: https://groups.io/mt/73215163/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
