On 03/07/20 01:01, Philippe Mathieu-Daudé wrote: > On 3/7/20 12:04 AM, Laszlo Ersek wrote: >> When the MDE_CPU_IA32 macro is not defined, there is no access to the >> "KernelImageHandle" local variable in QemuStartKernelImage(). This breaks >> the OvmfPkgIa32X64 and OvmfPkgX64 platform builds, at least with gcc-8. >> >> Move the local variable to the inner scope, where declaration and usage >> are inseparable. >> >> (Note that such inner-scope declarations are frowned upon in the wider >> edk2 codebase, but we use them liberally in ArmVirtPkg and OvmfPkg >> anyway, >> because they help us reason about variable lifetime and visibility.) >> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Philippe Mathieu-Daudé <phi...@redhat.com> >> Fixes: 7c47d89003a6f8f7f6f0ce8ca7d3e87c630d14cc >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2572 >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> > Tested-by: Philippe Mathieu-Daude <phi...@redhat.com>
Thank you, Phil, this really helps -- I want to push the patch as quickly as possible, due to it averting a build break. So I've submitted <https://github.com/tianocore/edk2/pull/428> with your tags applied... but mergify is apparently not picking up the "push" label again... I have no idea what's going on. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55625): https://edk2.groups.io/g/devel/message/55625 Mute This Topic: https://groups.io/mt/71785477/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
