Suspiciously, ArmLib's INF does not contain a [LibraryClasses] section at all, but it turns out that all the library includes it contains (except for ArmLib.h itself) are actually bogus so let's just drop all of them. While at it, replace <Uefi.h> with the more accurate <Base.h> for a BASE type module, and put the includes in a consistent order.
Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 9 +++++---- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 10 ++++++---- ArmPkg/Library/ArmLib/ArmLib.c | 2 -- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c index 0ed8dae9a4b0..924bf48020e0 100644 --- a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c +++ b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c @@ -7,11 +7,12 @@ **/ -#include <Uefi.h> -#include <Chipset/AArch64.h> +#include <Base.h> + #include <Library/ArmLib.h> -#include <Library/BaseLib.h> -#include <Library/IoLib.h> + +#include <Chipset/AArch64.h> + #include "AArch64Lib.h" #include "ArmLibPrivate.h" diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c index 38516d4f1b87..5d93aa6e0b8c 100644 --- a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c +++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c @@ -6,11 +6,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent **/ -#include <Uefi.h> -#include <Chipset/ArmV7.h> + +#include <Base.h> + #include <Library/ArmLib.h> -#include <Library/BaseLib.h> -#include <Library/IoLib.h> + +#include <Chipset/ArmV7.h> + #include "ArmV7Lib.h" #include "ArmLibPrivate.h" diff --git a/ArmPkg/Library/ArmLib/ArmLib.c b/ArmPkg/Library/ArmLib/ArmLib.c index c682c3ab6339..3905d02c5e7e 100644 --- a/ArmPkg/Library/ArmLib/ArmLib.c +++ b/ArmPkg/Library/ArmLib/ArmLib.c @@ -10,8 +10,6 @@ #include <Base.h> #include <Library/ArmLib.h> -#include <Library/DebugLib.h> -#include <Library/PcdLib.h> #include "ArmLibPrivate.h" -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55437): https://edk2.groups.io/g/devel/message/55437 Mute This Topic: https://groups.io/mt/71732165/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
